Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-views): Add a Share View button that persists the original view's name #78665

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MichaelSun48
Copy link
Member

Adds the "Share View" option to the ellipsis menu. This copies a version of the current url without the viewId query param, and with a viewName query param. This has the added feature that when someone else clicks on a shared link, the temporary tab that is selected will also have the original tab's name.

New menu option:

image

Temporary tab with new name:

image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../issueList/groupSearchViewTabs/draggableTabBar.tsx 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #78665       +/-   ##
===========================================
+ Coverage   67.59%   78.11%   +10.52%     
===========================================
  Files        7272     7103      -169     
  Lines      321264   312195     -9069     
  Branches    20966    50963    +29997     
===========================================
+ Hits       217149   243865    +26716     
+ Misses     103707    61992    -41715     
- Partials      408     6338     +5930     

@getsantry
Copy link
Contributor

getsantry bot commented Oct 27, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 27, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Nov 18, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 18, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 11, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 11, 2024
@MichaelSun48
Copy link
Member Author

bad bot

@getsantry getsantry bot removed the Stale label Dec 12, 2024
@MichaelSun48 MichaelSun48 changed the title Add a Share View button that persists the original view's name feat(issue-views): Add a Share View button that persists the original view's name Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant