Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(quota): Max limit of 2**32 - 1" #48353

Merged
merged 1 commit into from
May 3, 2023

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented May 2, 2023

Reverts #48057

As of getsentry/relay#2079, Relay is able to parse any positive integer < 2**64, so this workaround is no longer necessary.

@jjbayer jjbayer requested a review from a team May 2, 2023 17:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 2, 2023
@jjbayer jjbayer requested review from a team and leedongwei May 2, 2023 17:35
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #48353 (70c5718) into master (fa6fdea) will increase coverage by 5.58%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #48353      +/-   ##
==========================================
+ Coverage   75.33%   80.91%   +5.58%     
==========================================
  Files        4774     4775       +1     
  Lines      201707   201714       +7     
  Branches    11521    11521              
==========================================
+ Hits       151953   163222   +11269     
+ Misses      49499    38237   -11262     
  Partials      255      255              
Impacted Files Coverage Δ
src/sentry/quotas/base.py 96.45% <ø> (-0.20%) ⬇️

... and 639 files with indirect coverage changes

@jjbayer jjbayer merged commit 23cc3f5 into master May 3, 2023
@jjbayer jjbayer deleted the revert-48057-fix/quota-limit-gt-u32max branch May 3, 2023 08:39
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants