Better logo in dark mode #33799
Closed
Better logo in dark mode #33799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses Github's support for specifying which theme an image should be shown to: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to
dashed
approved these changes
Apr 20, 2022
|
There was some attempt at this in the SDKs that I think was inconclusive. @bruno-garcia @AbhiPrasad Do you remember? I think it was a third-party contribution. |
|
@untitaker @chadwhitacre Thanks! Do we render the docs for this repo anywhere else that this would be a concern? Edit: Looks like we also publish sentry to pypi, so this would probably be an issue there too. |
|
Closing until there's better support in other places that these docs are published. |
This was referenced Apr 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Github's support for specifying which theme an image should be shown to.
Before:
After: