ref(ts): Convert <SidebarOrgSummary> to typescript #16358

matejminar · 2020-01-09T15:18:01Z

No description provided.

The implementation of this function from django 1.9.13 covers more invalid URLs than the one from django-sudo does. We should not redirect to `http:123347` style URLs.

When updating Gravatar to typescript, I removed some property spreads as they triggered typescript warnings and the propTypes didn't cover any props that needed spreading. The onLoad and onError props were load bearing as they are used to handle gravatar fallbacks.

dashed

Looks good to me 👍

markstory · 2020-01-09T17:00:23Z

src/sentry/static/sentry/app/components/sidebar/sidebarOrgSummary.tsx

-    }
+  if (projects) {
+    // should we think about pluralization here?
+    extra.push(`${projects} projects`);


We likely should use tn() in the locale module to translation and pluralization.

used it, thanks 👍

- Shows a permission error if a user without access to events like a billing account tries to access discover

…text Have the trace_id and span_id use the built in columns instead of the context array.

This removes `LatestContext` dependency and fixes `ContextPickerModal` and refactors it to ts. Co-Authored-By: Matej Minar <[email protected]>

Also makes sure that the index redirects to combined alert listing view.

* Fetch tag values individually. This will let snuba use the promoted columns more effectively as they perform better. * Only get 10 facets by default. * Use a having clause instead of WHERE to exclude tracing tags as it performs better. * Don't use fields that unpack into arrayJoin() expressions where possible. * Enable sampling at lower project thresholds, as we don't need full accuracy.

Remove SnubaEvent since we are moving towards a single event model (eventstore/models/Event) everywhere.

If an event hasn't been propagated when the user report is created, then queue a task to sync the event data once it's stored fully.

Fixes getsentry/self-hosted#322

Fixes getsentry/self-hosted#332

The route for sentry-organization-auth-settings was still located in the old settings path, this route is used for a redirect in the auth.helper module when there is a problem configuring SSO. This just corrects the redirect so it goes back to settings instead of 404ing.

The `sentry:user` tag can come back null when it is read from the promoted columns. Handling nulls allows get_tag_value_label() to be used more broadly.

Remove the automatic dataset detection logic from sentry. We have switched over to the snuba based implementation of this. Not having dataset selection in sentry also means we can remove some (but not all) of the supporting logic as well.

This disables all form fields when editing a Metric Alert without the `org:write` role.

billyvg · 2020-01-09T15:57:27Z

src/sentry/static/sentry/app/components/sidebar/sidebarOrgSummary.tsx


-    return (
-      <OrgSummary>
-        <OrganizationAvatar css={{flexShrink: 0}} organization={organization} size={36} />


css is a legitimate prop here via emotion

That's what I thought, but after inspection, I found out that the css prop was not being applied here at all, that's why I changed it to style, which is according to underlying components' types being passed down and applied to the final element. But anyway, the final element (StyledBaseAvatar in app/components/avatar/baseAvatar) has flex-shrink: 0 by default, so do you think we can keep it removed altogether?

It does look like it's being applied, this is from production (I believe it's this component):

Yes, it should be that component, but it's flex-shrink comes imho from:

sentry/src/sentry/static/sentry/app/components/avatar/baseAvatar.tsx

Lines 240 to 244 in 893720d

const StyledBaseAvatar = styled('span')<{round: boolean; loaded: boolean}>`

flex-shrink: 0;

${p => !p.loaded && 'background-color: rgba(200, 200, 200, 0.1);'};

${p => p.round && 'border-radius: 100%;'};

`;

Ah, cool, let's kill it then

awesome, thank you

…y into ref/ts/sidebarOrgSummary

…ted to relative (#16385)

The facets endpoint is still not fast. I want to see what kind of results can be obtained if we aggressively sample tag values. If this yields acceptable performance I want to try scaling the sampling rate based on the data volume so that we can better balance accurracy and performance.

Try #2, use a timed retry policy

…6291) * fix(discover2): Test fix on Percy snapshots * fix(discover2): Improve QueryBuilder for error/loading states * fix(discover2): Resize QueryBuilder when browser is resized

Register option for #16285

This removes the UI components that fetch and render related issues on the Incidents details view.

Move the implementation into the Pagerduty plugin since this is the only place it is used.

Add spans to collect more information about snuba queries. Having the referrer and the start of the query body should make tracking down slow queries in snuba easier as we have more context.

This removes the UI and endpoint to create a manual incident.

This was used on the Incidents details view, but is no longer used

Outputting the raw data when we also output all the formatted keys wastes space and adds visual noise.

…dent spans for the ops breakdown (#16377)

* ref(ui): Refactor `cx` from emotion to `classnames` We generally use the `classnames` library to handle merging/dynamic `className`. No reason to use two different libraries. * upgrade emotion, add styled wrapper for typings (and related paths), add eslint rules for emotion, update babel plugin * Refactor usage of emotion `css` being treated as a class name string * change innerRef --> ref * refactor grid-emotion props and update to `reflexbox` * eslint for emotion-setup * refactor injectGlobal --> Global for emotion upgrade * Add <CacheProvider>, this is needed to turn speedy off for percy * refactor <HeaderItem> - fix missing props to styled components, remove innerRef and forwardRef * Change <Tooltip> logic for when to apply a wrapper, emotion causes the previously expected types to be different * random TS fixes for styled components * fix <RadioGroup> animation needing `css` * forwardRef for Switch * define a `theme.space` for rebass/grid * fix DOM attribute warnings with "loading" prop * fix settings breadcrumb - Box in `reflexbox` has different CSS than grid-emotion * change <ProviderRow> to remove `Flex` around CircleIndicator as it was squishing it on small widths * css fixes for percy * fix featureDisabled logic for custom alerts because emotion * refactor emotion9 --> emotion10 (imports) * update snapshots and fix tests

Fixes links to screenshots in README.md broken by 983c8c6

* ref(ts): Convert <SearchBar> to typescript * removed proptypes, placeholder optional

matejminar added 2 commits January 9, 2020 16:10

ref(ts): Convert <SidebarOrgSummary> to typescript

fbd3b6b

comment

f8e51fa

matejminar requested a review from a team January 9, 2020 15:18

markstory added 2 commits January 9, 2020 10:28

fix: Use django's is_safe_url function (#16337)

847084f

The implementation of this function from django 1.9.13 covers more invalid URLs than the one from django-sudo does. We should not redirect to `http:123347` style URLs.

dashed approved these changes Jan 9, 2020

View reviewed changes

Removing unused class (#16278)

4fed714

markstory reviewed Jan 9, 2020

View reviewed changes

wmak and others added 20 commits January 9, 2020 12:35

fix(discover) - Show errors if we encounter them loading discover

15d0680

- Shows a permission error if a user without access to events like a billing account tries to access discover

feat(discover) Switch trace and span id to use columns instead of con…

d5f6bea

…text Have the trace_id and span_id use the built in columns instead of the context array.

fix(ui): Fix <ContextPickerModal> and refactor to ts (#16090)

ec7a56d

This removes `LatestContext` dependency and fixes `ContextPickerModal` and refactors it to ts. Co-Authored-By: Matej Minar <[email protected]>

fix(ui): Fix redirect after creating/editing Metric Alert rules (#16342)

f0fbd49

Also makes sure that the index redirects to combined alert listing view.

fix(saml2): Improve error message on attribute mapping (#16347)

5b0218e

ref: Remove SnubaEvent (#16309)

4c2825f

Remove SnubaEvent since we are moving towards a single event model (eventstore/models/Event) everywhere.

fix(tasks) Add event data to user report asynchronously

ecbdbd8

If an event hasn't been propagated when the user report is created, then queue a task to sync the event data once it's stored fully.

feat(django): pytest startup and test collection on Django 1.11 (#16105)

e171b81

chore: cleanup bitfield (#16031)

453a1e3

fix(migrations): Make Snuba event migration more robust (#16364)

be7bb6f

Fixes getsentry/self-hosted#322

feat(teams): Update open membership team permissions (#16244)

6722ac0

fix(migrations): Fix prerequisite for jira_ac migration (#16351)

ebe82a6

Fixes getsentry/self-hosted#332

fix: Remove beta tag on PagerDuty integration (#16344)

431a42a

fix(tagstore) Don't explode on null values (#16368)

3572a1a

The `sentry:user` tag can come back null when it is read from the promoted columns. Handling nulls allows get_tag_value_label() to be used more broadly.

feat(ui): Require org:write role for Metric Alerts form (#16340)

069e374

This disables all form fields when editing a Metric Alert without the `org:write` role.

ref(ts) Move BadgeDisplayName to typescript (#16361)

944e58c

test: fix remaining Django 1.11 tests and make required (#16367)

2cf637e

billyvg reviewed Jan 9, 2020

View reviewed changes

fix(saml): Wrap individual idp config tabs with forms (#16373)

4f3c924

matejminar added 4 commits January 10, 2020 10:22

translation+pluralization

4709ec9

removed duplicate style

6bf25bf

removed duplicate style

6afb859

Merge branch 'ref/ts/sidebarOrgSummary' of github.com:getsentry/sentr…

c985f01

…y into ref/ts/sidebarOrgSummary

matejminar requested a review from billyvg January 10, 2020 10:28

matejminar and others added 7 commits January 10, 2020 13:17

fix(ui): Fixed alignment in <TogglableAddress> if it cannot be conver…

7ee75b9

…ted to relative (#16385)

test(acceptance): Try #2 to fix flakey onboarding test for dja… (#16345)

8bcf2af

Try #2, use a timed retry policy

fix(discover2): Fix Percy snapshots and UX issues on Querybuilder (#1…

3c32866

…6291) * fix(discover2): Test fix on Percy snapshots * fix(discover2): Improve QueryBuilder for error/loading states * fix(discover2): Resize QueryBuilder when browser is resized

feat: Register option for eventstream (#16363)

7f451b2

Register option for #16285

feat(alerts): Remove "Related issues" from incidents (#16379)

a8c8cca

This removes the UI components that fetch and render related issues on the Incidents details view.

ref: Deprecate get_legacy_message (#16310)

f00ec17

Move the implementation into the Pagerduty plugin since this is the only place it is used.

billyvg approved these changes Jan 10, 2020

View reviewed changes

markstory and others added 14 commits January 10, 2020 14:39

feat(tracing) Add spans for snuba queries (#16388)

d805fe0

Add spans to collect more information about snuba queries. Having the referrer and the start of the query body should make tracking down slow queries in snuba easier as we have more context.

feat(workflow): Remove "Create incident" manual workflow and e… (#16375)

c167068

This removes the UI and endpoint to create a manual incident.

feat: upgrade drf to 3.6.4 (#16392)

d1ab22f

feat(alerts): Remove "Suspects" UI and endpoint (#16378)

677415e

This was used on the Incidents details view, but is no longer used

ref(discover) Remove the raw field (#16390)

edf8843

Outputting the raw data when we also output all the formatted keys wastes space and adds visual noise.

fix(discover2): Use transaction root span only if there are no descen…

348f90a

…dent spans for the ops breakdown (#16377)

feat(drf): Add CamelSnakeSerializer (#16397)

3613eca

docs(workflow): Fix link to screenshots in README.md (#16404)

d49f64d

Fixes links to screenshots in README.md broken by 983c8c6

ref(ts): Convert <QueryCount> to typescript (#16356)

c59b4d4

ref(ts): Convert <SearchBar> to typescript (#16357)

6bef54b

* ref(ts): Convert <SearchBar> to typescript * removed proptypes, placeholder optional

ref(ts): Convert getOnboardingTasks to typescript (#16348)

be4e290

merge

1013aad

Merge branch 'ref/ts/sidebarOrgSummary'

4f566b4

matejminar merged commit 7d72067 into master Jan 13, 2020

matejminar deleted the ref/ts/sidebarOrgSummary branch January 13, 2020 10:21

github-actions bot locked and limited conversation to collaborators Dec 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref(ts): Convert <SidebarOrgSummary> to typescript #16358

ref(ts): Convert <SidebarOrgSummary> to typescript #16358

matejminar commented Jan 9, 2020

dashed left a comment

markstory Jan 9, 2020

matejminar Jan 10, 2020

billyvg Jan 9, 2020

matejminar Jan 10, 2020 •

edited

Loading

billyvg Jan 10, 2020

matejminar Jan 10, 2020 •

edited

Loading

billyvg Jan 10, 2020

matejminar Jan 10, 2020

	const StyledBaseAvatar = styled('span')<{round: boolean; loaded: boolean}>`
	flex-shrink: 0;
	${p => !p.loaded && 'background-color: rgba(200, 200, 200, 0.1);'};
	${p => p.round && 'border-radius: 100%;'};
	`;

ref(ts): Convert <SidebarOrgSummary> to typescript #16358

ref(ts): Convert <SidebarOrgSummary> to typescript #16358

Conversation

matejminar commented Jan 9, 2020

dashed left a comment

Choose a reason for hiding this comment

markstory Jan 9, 2020

Choose a reason for hiding this comment

matejminar Jan 10, 2020

Choose a reason for hiding this comment

billyvg Jan 9, 2020

Choose a reason for hiding this comment

matejminar Jan 10, 2020 • edited Loading

Choose a reason for hiding this comment

billyvg Jan 10, 2020

Choose a reason for hiding this comment

matejminar Jan 10, 2020 • edited Loading

Choose a reason for hiding this comment

billyvg Jan 10, 2020

Choose a reason for hiding this comment

matejminar Jan 10, 2020

Choose a reason for hiding this comment

matejminar Jan 10, 2020 •

edited

Loading

matejminar Jan 10, 2020 •

edited

Loading