chore(billing): Add app_service.get_internal_integrations #84335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #84335 +/- ##
===========================================
+ Coverage 46.59% 87.61% +41.02%
===========================================
Files 9578 9594 +16
Lines 542304 543084 +780
Branches 21275 21275
===========================================
+ Hits 252661 475844 +223183
+ Misses 289286 66883 -222403
Partials 357 357 |
brendanhsentry
approved these changes
Jan 30, 2025
markstory
reviewed
Jan 31, 2025
| owner_id=organization_id, | ||
| status=SentryAppStatus.INTERNAL, | ||
| name=integration_name, | ||
| ) |
There was a problem hiding this comment.
Will each organization be getting a distinct sentryapp? Or will there be one sentry app for vercel and each organization has an installation?
There was a problem hiding this comment.
Each organization will have their own Vercel SentryApp. We do this since the access token tied to each organization will be stored in the SentryApp's metadata.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
Closes #84333 We will need this for Vercel billing integration; and to be able to retrieve the `SentryApp` corresponding to the Vercel native marketplace integration from within the region silo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84333
We will need this for Vercel billing integration; and to be able to retrieve the
SentryAppcorresponding to the Vercel native marketplace integration from within the region silo.