Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metric-issues): Add project-level flag for metric issues #84316

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

snigdhas
Copy link
Member

We already have an organization level flag, but this project level flag helps us test internally with lesser used projects before we enable it for all of Sentry.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/incidents/utils/metric_issue_poc.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #84316      +/-   ##
==========================================
- Coverage   87.64%   87.64%   -0.01%     
==========================================
  Files        9579     9580       +1     
  Lines      542536   542553      +17     
  Branches    21264    21264              
==========================================
+ Hits       475514   475524      +10     
- Misses      66670    66677       +7     
  Partials      352      352              

@snigdhas snigdhas marked this pull request as ready for review January 30, 2025 17:57
@snigdhas snigdhas requested a review from a team as a code owner January 30, 2025 17:57
@snigdhas snigdhas requested a review from a team January 30, 2025 17:57
@snigdhas snigdhas enabled auto-merge (squash) January 30, 2025 18:04
@snigdhas snigdhas merged commit b36be14 into master Jan 30, 2025
49 checks passed
@snigdhas snigdhas deleted the snigdha/metric-issue-proj-flag branch January 30, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants