Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate project cardinality limit option using rust validation functions #69750

Closed
Tracked by #70219
ArthurKnaus opened this issue Apr 26, 2024 · 0 comments · Fixed by #70217
Closed
Tracked by #70219

Validate project cardinality limit option using rust validation functions #69750

ArthurKnaus opened this issue Apr 26, 2024 · 0 comments · Fixed by #70217
Assignees
@ArthurKnaus

Comments

@ArthurKnaus
Copy link
Member

No description provided.

This was referenced Apr 26, 2024
Merged
Merged
@ArthurKnaus ArthurKnaus self-assigned this Apr 29, 2024
ArthurKnaus added a commit to getsentry/relay that referenced this issue Apr 30, 2024
@ArthurKnaus @iker-barriocanal
feat(relay-cabi): Expose cardinality limit validation (#3489)
1f60882 
Expose `relay_validate_cardinality_limit_config` to enable validation in
`sentry` repo.

Relates to getsentry/sentry#69750

#skip-changelog

---------

Co-authored-by: Iker Barriocanal <[email protected]>
@ArthurKnaus ArthurKnaus mentioned this issue May 3, 2024
Merged
@matejminar matejminar mentioned this issue May 3, 2024
Closed
@ArthurKnaus ArthurKnaus mentioned this issue May 3, 2024
Merged
ArthurKnaus added a commit that referenced this issue May 21, 2024
@ArthurKnaus
feat(cardinality-limit): Improve validation (#70217)
5b11583 
Add upper limit for cardinality limit value.
Add tests that ensures that the generated limit is normalized.

Closes #69750
cmanallen pushed a commit that referenced this issue May 21, 2024
@ArthurKnaus @cmanallen
feat(cardinality-limit): Improve validation (#70217)
29cda22 
Add upper limit for cardinality limit value.
Add tests that ensures that the generated limit is normalized.

Closes #69750
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArthurKnaus ArthurKnaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cardinality-limit): Improve validation getsentry/sentry
1 participant
@ArthurKnaus