Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out known browser errors #61469

Closed
Tracked by #59564
scefali opened this issue Dec 8, 2023 · 4 comments
Closed
Tracked by #59564

Filter out known browser errors #61469

scefali opened this issue Dec 8, 2023 · 4 comments
Assignees

Comments

@scefali
Copy link
Contributor

scefali commented Dec 8, 2023

Introduction

There are a number of browser errors that are known to cause problems to Developers. These errors are not actionable nor do they impact the user experience. Therefore, we believe these should be filtered automatically under a new filter called Known Browser Errors.

__gCrWeb is undefined

We sometimes see errors like undefined is not an object (evaluating '__gCrWeb.instantSearch.setIOSParameters') get into Sentry's issues feed. The object __gCrWeb get injected via script by the browser on iOS devices. Google needs to do this for some extended functionality (mostly inserting/retrieving login credentials and other form information you stored via another synced Chrome browser) which isn't provided by the native webview it's built on and can't be added to it otherwise. Since this functionality isn't required for the website to work, the recommendation is to filter out thes errors.

For more info, see this Stack Overflow thread. For insights into how much this is happening in Sentry, see here.

null is not an object (evaluating 'Object.prototype.hasOwnProperty.call(o,"telephone")')

The error null is not an object (evaluating 'Object.prototype.hasOwnProperty.call(o,"telephone")') seems to be another browser bug. There aren't any public discussion on this (aside from this Twitter thread) but the conclusion seems to be this is a Safari specific bug in parsing certain JSON-LD content. It tries to parse the schema of an organization (which isn't even present in the schema) and fails. Doesn't seem to have any user impact and it's not actionable to the user. Weirdly enough, it also seems to only impact Next.js but there isn't a clear reason why that's true.

TODO: add stack trace info

@scefali scefali self-assigned this Dec 8, 2023
@pattonwebz
Copy link

pattonwebz commented Dec 13, 2023

The null is not an object (evaluating 'Object.prototype.hasOwnProperty.call(o,"telephone")') error I see too and also believe it is non-actionable browser bug from Safari (both desktop and mobile safari). I see this in my properties as well but they are not Next.js (one is WordPress, the other is Shopify).

@scefali
Copy link
Contributor Author

scefali commented Jan 5, 2024

I think we need a bit more examples of these kinds of errors with higher impact if we want to pursue adding a new filter. Closing for now.

@scefali scefali closed this as completed Jan 5, 2024
@scefali
Copy link
Contributor Author

scefali commented Jan 11, 2024

For the issue null is not an object (evaluating 'Object.prototype.hasOwnProperty.call(o,"telephone")'), you can use the following inbound filter:

*Object.prototype.hasOwnProperty.call(o,"telephone")*

Docs on inbound filters: https://docs.sentry.io/product/data-management-settings/filtering/#error-message

@remy33
Copy link

remy33 commented Jan 15, 2024

There is a workaround that you can try as mentioned here

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants