Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of "Clear Feed" #269

Closed
kbrownlees opened this issue Nov 27, 2011 · 2 comments
Closed

Behaviour of "Clear Feed" #269

kbrownlees opened this issue Nov 27, 2011 · 2 comments

Comments

@kbrownlees
Copy link

Currently clear feed clears the entire feed (GroupedMessage.objects.all().update(status=1)). This behaviour seems counter intuitive to me:

  1. there would seem to be a race condition which means you could clear something you are yet to read?
  2. I feel only what I am currently filtered on should be cleared. ie, if I am currently viewing based on a certain logger I would expect only the entries from that logger to be cleared.

I have quickly implemented point two in https://github.com/kbrownlees/django-sentry/commit/543ca928cbe9787f7a545aab1aac47caf05a5501

Thoughts and suggestions are most welcome :)

@rassie
Copy link

rassie commented Nov 27, 2011

I'm all for point 2! Been bitten by this several times (nothing too critical, but still).

@dcramer
Copy link
Member

dcramer commented May 10, 2012

Issue #2 was fixed. Going to close this and will address the other issue later (as its much more complicated)

@dcramer dcramer closed this as completed May 10, 2012
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants