Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic release detection naming conflict with Github Action #2114

Closed
d-wierdsma opened this issue Sep 22, 2023 · 0 comments · Fixed by #2174
Closed

Automatic release detection naming conflict with Github Action #2114

d-wierdsma opened this issue Sep 22, 2023 · 0 comments · Fixed by #2174
Assignees
Labels

Comments

@d-wierdsma
Copy link

Currently when you are utilizing the Sentry Ruby SDK if you do not specify a release name, it uses git-based automatic detection which uses a git rev-parse --short HEAD command.

This works nicely, however when creating a release using the Github Action Sentry Release the only option is to use the full SHA as it is all that Github exposes as a variable. This release is preferable to default to as it associates commits with the release and gives you a clearer picture of what is broken

For example you can wind up with two releases within your sentry project:

  • one f029dd0a822e8e99e19ee50f21a7 with github commits associated and files changed
  • another f029dd0 that has the actual errors being sent to it

Would it be possible to change the Sentry Ruby Gem to use the full SHA with git rev-parse HEAD to align with the Github Action?

FWIW this change has already been discussed and changed by the sentry-python SDK a few years back. getsentry/sentry-python#908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants