Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom setExtra and setTag values are not showing in version: 1.3.7 #826

Closed
5 of 11 tasks
gokulp-rn opened this issue Apr 24, 2020 · 6 comments
Closed
5 of 11 tasks

Comments

@gokulp-rn
Copy link

gokulp-rn commented Apr 24, 2020

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native
  • react-native-sentry

SDK version: 1.3.7
react-native version: 0.60.5

Are you using Expo?

  • Yes
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

Configuration:

Sentry.init({
  dsn: 'https://[email protected]/...'
});

I have following issue:
Sentry.setExtra and Sentry.setTag values are not showing in sentry issue dashboard

Also checked using beforeSend
Custom extras and tags are not showing, only

extra: { componentStack: '[undefined]', jsEngine: 'hermes' },
tags: { hermes: 'true' },

Steps to reproduce:

  • Update sentry sdk to 1.3.7

Actual result:

  • Not showing custom tags and extras

Expected result:

  • Should show custom tags and extras
@krizzVX
Copy link

krizzVX commented May 18, 2020

I have a similar Issue. In my case, i set two tags, but in the dashboard only shows one.

@marandaneto
Copy link
Contributor

@jennmueng are you aware of this? trying to reproduce this would be the first step.

@Aung-Myint-Thein
Copy link

I found something which might be related to this.

I was setting tags using a dictionary back in 1.3.4 using setTag() and it is working fine. However, in 1.7.2 the function is changed and it is expecting only strings and introduced a new function called setTags().

Maybe I missed that out in upgrade guide but I cannot really find it. So, would be nice if we can add it in the guides here 🙂

https://docs.sentry.io/platforms/javascript/enriching-error-data/additional-data/adding-tags/

Thanks!

@Aung-Myint-Thein
Copy link

@marandaneto happy to send a PR 🙂 if it will be helpful.

@marandaneto
Copy link
Contributor

@Aung-Myint-Thein that's true.

I think that change doesn't reflect on all the other SDKs that depend on sentry-javascript, yet.

What's about adding to the README? there's a How to use it section and setTags is indeed missing.
Would you like to send a PR? :) thanks!

@marandaneto
Copy link
Contributor

Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated. There's a large chance that this issue has been solved since.
Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
Cheers!

for the docs issue: getsentry/sentry-docs#4275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants