-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to have a specific flag to disable upload debug symbol build phase #4056
Comments
Hi @Lucienzera, The |
@krystofwoldrich understandable, because we have another layer for obfuscation and hardening to our ipa. We require to only upload the files after the hardening process is done instead of during the build process. Its not that we dont want Sentry disabled build release version local, we just want to move the upload process after everything is done instead of during. |
Thank you for the details @Lucienzera We decided to add a separate env to only disable native debug files upload. |
Specs
SDK Version: @sentry/react-native: 5.28.0
RN Version: 0.74.5
expo: 51.0.26
OS:
Platform:
Are you using Expo?
Are you using sentry.io or on-premise?
Context
Our expo managed react native application consists of hardening process that is done after an
.ipa
is generated. We use the expo plugin to connect the application with Sentry. This also addsUpload Debug Symbol for Sentry
step into the build phases.The hardening process will make some changes to the Debug Information Files, so we are required to use upload this new one into Sentry Dashboard instead of the one uploaded during the build phase.
Current workaround
We are required to patch the package and add a Release check under
sentry-dexcode-debug-files.sh
to disable the build phase step.Request
To have a specific flag to disable this step entirely, something like
SENTRY_DISABLE_DIF_UPLOAD
. Instead of using the generalSENTRY_DISABLE_AUTO_UPLOAD
.Was the reasoning to coupled both sourcemap and DIF upload to a single flag, under the assumption that if a dev makes some changes towards it they would be changing both js and native bundles?
The text was updated successfully, but these errors were encountered: