From 3eaf2e2d4d0b4b23421c41c2bb9b5ebd9c109064 Mon Sep 17 00:00:00 2001 From: lucas Date: Wed, 11 Dec 2024 18:19:02 +0000 Subject: [PATCH] WIP --- .github/workflows/sample-application-expo.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/sample-application-expo.yml b/.github/workflows/sample-application-expo.yml index f193ce80e7..79257ed7d9 100644 --- a/.github/workflows/sample-application-expo.yml +++ b/.github/workflows/sample-application-expo.yml @@ -20,7 +20,7 @@ jobs: uses: ./.github/workflows/skip-ci.yml build: - name: Build ${{ matrix.rn-architecture }} ${{ matrix.platform }} ${{ matrix.build-type }} ${{ matrix.ios-use-frameworks}} + name: Build ${{ matrix.platform }} ${{ matrix.build-type }} ${{ matrix.ios-use-frameworks}} runs-on: ${{ matrix.runs-on }} needs: [diff_check] if: ${{ needs.diff_check.outputs.skip_ci != 'true' }} @@ -30,7 +30,6 @@ jobs: # we want that the matrix keeps running, default is to cancel them if it fails. fail-fast: false matrix: - rn-architecture: ['legacy', 'new'] ios-use-frameworks: ['no-frameworks', 'dynamic-frameworks'] platform: ['android', 'ios', 'macos'] build-type: ['dev', 'production'] @@ -44,8 +43,6 @@ jobs: exclude: - platform: 'android' ios-use-frameworks: 'dynamic-frameworks' - - rn-architecture: 'new' - ios-use-frameworks: 'dynamic-frameworks' steps: - uses: actions/checkout@v4 @@ -92,7 +89,6 @@ jobs: [[ "${{ matrix.platform }}" == "ios" ]] && cd expo/ios [[ "${{ matrix.build-type }}" == "production" ]] && ENABLE_PROD=1 || ENABLE_PROD=0 - [[ "${{ matrix.rn-architecture }}" == "new" ]] && ENABLE_NEW_ARCH=1 || ENABLE_NEW_ARCH=0 [[ "${{ matrix.ios-use-frameworks }}" == "dynamic-frameworks" ]] && export USE_FRAMEWORKS=dynamic echo "ENABLE_PROD=$ENABLE_PROD" echo "ENABLE_NEW_ARCH=$ENABLE_NEW_ARCH" @@ -141,5 +137,5 @@ jobs: if: ${{ always() }} uses: actions/upload-artifact@v4 with: - name: build-sample-${{ matrix.rn-architecture }}-${{ matrix.platform }}-${{ matrix.build-type }}-${{ matrix.ios-use-frameworks}}-logs - path: samples/react-native/${{ matrix.platform }}/*.log + name: build-sample-expo-${{ matrix.platform }}-${{ matrix.build-type }}-${{ matrix.ios-use-frameworks}}-logs + path: samples/expo/${{ matrix.platform }}/*.log