Add range of executing node to frames #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
reviewed
Jul 15, 2020
| @@ -217,35 +216,6 @@ def test_with_locals_disabled(sentry_init, capture_events): | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("integrations", [[], [ExecutingIntegration()]]) | |||
There was a problem hiding this comment.
Oh damn, thanks! Seems like I overlooked this.
untitaker
approved these changes
Jul 15, 2020
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
I think this and #748 might as well be left closed unless getsentry/sentry#19924 is going to be reopened. |
|
thx @alexmojaki, I'm just bringing this repo back to life and had to do some bulk changes, sorry for the confusion/notification spam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #748
When ExecutingIntegration is enabled, each frame in an exception traceback now contains new data that looks like this:
This can be used to highlight exactly what the frame was doing, rather than just a line. Actually doing this will also require work on the server.
The line numbers may actually go beyond the amount of context that's been included, I don't know if that's something we want to address at this stage.