Use sentry_init fixture in tests instead of using Hub directly #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Jul 10, 2020
| @@ -149,41 +156,41 @@ def test_proxy_httpsselect_bothenv_http(monkeypatch): | |||
| assert client.transport._pool.proxy.scheme == "http" | |||
|
|
|||
|
|
|||
| def test_simple_transport(): | |||
| def test_simple_transport(sentry_init): | |||
| events = [] | |||
There was a problem hiding this comment.
You do not need to pass in a transport if you're using sentry_init, just use the capture_events fixture instead which does the same thing.
There was a problem hiding this comment.
I did that at first but then decided that wasn't in the spirit of the original test and the name test_simple_transport.
|
Thanks! Not entirely sure why project coverage is still there. I think I disabled it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@untitaker how's this?
Based on #749 (comment)