Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new before_serialize_vars hook #3413

Closed
sl0thentr0py opened this issue Aug 8, 2024 · 1 comment
Closed

Add new before_serialize_vars hook #3413

sl0thentr0py opened this issue Aug 8, 2024 · 1 comment
Assignees

Comments

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Aug 8, 2024

hmm @philipstarkey I see, that's a valid concern.

So the reason I looked at this again was because of a report where we patch the original f_locals and actually potentially break user code. We should generally not be holding the original variable references for longer than necessary.

Further, the scrubber was meant to be a simpler before_send with a simple denylist so that people can remove some vars by name easily from the event payload.

I'm going to go ahead with merging this PR, but at the same time I will expose another before_serialize_vars (naming TBD) that you can hook into to do precisely what you want in a separate PR.

Originally posted by @sl0thentr0py in #3409 (comment)

@sl0thentr0py
Copy link
Member Author

closing in favor of #3427

@sl0thentr0py sl0thentr0py closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant