From 68fb0b4c7e420df4cfa6239d256fc4d0a9e32ff1 Mon Sep 17 00:00:00 2001 From: Markus Unterwaditzer Date: Wed, 3 Mar 2021 14:57:49 +0100 Subject: [PATCH] fix(worker): Log data-dropping events with error (#1032) Co-authored-by: sentry-bot --- sentry_sdk/worker.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sentry_sdk/worker.py b/sentry_sdk/worker.py index b528509cf6..a8e2fe1ce6 100644 --- a/sentry_sdk/worker.py +++ b/sentry_sdk/worker.py @@ -99,11 +99,14 @@ def _wait_flush(self, timeout, callback): # type: (float, Optional[Any]) -> None initial_timeout = min(0.1, timeout) if not self._timed_queue_join(initial_timeout): - pending = self._queue.qsize() + pending = self._queue.qsize() + 1 logger.debug("%d event(s) pending on flush", pending) if callback is not None: callback(pending, timeout) - self._timed_queue_join(timeout - initial_timeout) + + if not self._timed_queue_join(timeout - initial_timeout): + pending = self._queue.qsize() + 1 + logger.error("flush timed out, dropped %s events", pending) def submit(self, callback): # type: (Callable[[], None]) -> None @@ -115,7 +118,7 @@ def submit(self, callback): def on_full_queue(self, callback): # type: (Optional[Any]) -> None - logger.debug("background worker queue full, dropping event") + logger.error("background worker queue full, dropping event") def _target(self): # type: () -> None