crashpad_handler does not get build on macOS with vcpkg

[kelteseth]

Description

crashpad_handler does not get build on macOS with vcpkg. The tool simply is not build via vcpkg on macOS. This results in an invalid cmake file:

[0/1 ?/sec] Re-running CMake...
CMake Error at ScreenPlay/Common/vcpkg/scripts/buildsystems/vcpkg.cmake:366 (_add_executable):
  _add_executable cannot create imported target "sentry_crashpad::handler"
  because another target with the same name already exists.
Call Stack (most recent call first):
  ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry_crashpad-targets.cmake:115 (add_executable)
  ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry-config.cmake:34 (include)
  ScreenPlay/Common/vcpkg/scripts/buildsystems/vcpkg.cmake:478 (_find_package)
  ScreenPlay/ScreenPlay/CMakeLists.txt:22 (find_package)


CMake Error at ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry_crashpad-targets.cmake:135 (message):
  The imported target "sentry_crashpad::handler" references the file

     "/Users/ihaitemini/Documents/screenplayinternal/ScreenPlay/Common/vcpkg/installed/x64-osx/tools/sentry-native/crashpad_handler"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "/Users/ihaitemini/Documents/screenplayinternal/ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry_crashpad-targets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry-config.cmake:34 (include)
  ScreenPlay/Common/vcpkg/scripts/buildsystems/vcpkg.cmake:478 (_find_package)
  ScreenPlay/ScreenPlay/CMakeLists.txt:22 (find_package)


-- Configuring incomplete, errors occurred!

Looking at the vcpkg file -> https://github.com/microsoft/vcpkg/blob/49c1b2889def046f875138f06878c939d1ee9793/ports/sentry-native/portfile.cmake#L52
It is disabled for any none win32

When does the problem happen

• During build
• During run-time
• When capturing a hard crash

Environment

• OS: [macOS 10.15.6]
• Compiler: [e.g. Clang 10]
• CMake version and config: [3.17.2]

Steps To Reproduce

1. Clone ScreenPlay branch mac_fixes:
   • https://gitlab.com/kelteseth/ScreenPlay/-/tree/refactor/mac_fixes
2. Run install_dependencies_linux_mac.sh
3. Follow https://gitlab.com/kelteseth/ScreenPlay/-/blob/refactor/mac_fixes/Docs/DeveloperSetup.md

Log output

[kelteseth]

Ok removing the if WIN32 successfully creates the crashpad_handler. Now it complains about other things:

Führe /Users/ihaitemini/Qt/Tools/CMake/CMake.app/Contents/bin/cmake -S /Users/ihaitemini/Documents/screenplayinternal -B /private/var/folders/n4/lj16683928d9tmqx1jvxt2s40000gn/T/QtCreator-zLxJqS/qtc-cmake-UiMgPrgE in /private/var/folders/n4/lj16683928d9tmqx1jvxt2s40000gn/T/QtCreator-zLxJqS/qtc-cmake-UiMgPrgE aus.
CMake Error at ScreenPlay/Common/vcpkg/scripts/buildsystems/vcpkg.cmake:366 (_add_executable):
  _add_executable cannot create imported target "sentry_crashpad::handler"
  because another target with the same name already exists.
Call Stack (most recent call first):
  ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry_crashpad-targets.cmake:115 (add_executable)
  ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry-config.cmake:34 (include)
  ScreenPlay/Common/vcpkg/scripts/buildsystems/vcpkg.cmake:478 (_find_package)
  ScreenPlay/ScreenPlay/CMakeLists.txt:22 (find_package)


CMake Error at ScreenPlay/Common/vcpkg/installed/x64-osx/share/sentry/sentry-config.cmake:42 (set_property):
  Property INTERFACE_LINK_LIBRARIES may not contain link-type keyword
  "optimized".  The INTERFACE_LINK_LIBRARIES property may contain
  configuration-sensitive generator-expressions which may be used to specify
  per-configuration rules.
Call Stack (most recent call first):
  ScreenPlay/Common/vcpkg/scripts/buildsystems/vcpkg.cmake:478 (_find_package)
  ScreenPlay/ScreenPlay/CMakeLists.txt:22 (find_package)

[Swatinem]

I think this is rather a problem with the package in vcpkg, and you should probably report this upstream.

[david-antiteum]

@kelteseth Can you please try my version of the port?

https://github.com/david-antiteum/vcpkg-ports/tree/master/ports/sentry

Note that I'm using 0.4.1, you can update it to 0.4.2 changing GIT_REF

To use it you must use the --overlay-ports option

Will you contact the author of the port in vcpkg (AenBleidd)?

[Swatinem]

CMake Error at ScreenPlay/Common/vcpkg/scripts/buildsystems/vcpkg.cmake:366 (_add_executable):
  _add_executable cannot create imported target "sentry_crashpad::handler"
  because another target with the same name already exists.

Just noticed that. I think this is the same problem as #504 and should be fixed soon by getsentry/crashpad#37

[kelteseth]

@Swatinem thanks! I will enable my sentry for macos if this is merged :)