Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a callback with sentry_options_set_before_send does not fire under Windows #250

Closed
Rubonnek opened this issue May 5, 2020 · 4 comments · Fixed by #519
Closed
Labels
enhancement New feature or request

Comments

@Rubonnek
Copy link

Rubonnek commented May 5, 2020

I'm currently using the before-send callback under Linux to do my own crash post-processing, but this before_send callback does not fire under Windows.

@Swatinem Swatinem added the enhancement New feature or request label May 5, 2020
@Swatinem
Copy link
Member

Swatinem commented May 5, 2020

This is a known issue, as on windows we use crashpad which is out-of-process, and does its own sending, which is independent of our whole transport mechanism.

We would need to do more research into figuring out how to actually send everything through our own infrastructure on next startup. But its not really high priority ATM.

@daxpedda
Copy link
Contributor

daxpedda commented Jun 19, 2020

Considering that we now merged the breakpad and inproc backend for windows, I was trying it out now, without avail.
So I tried on Linux, which also doesn't work.

OS: Windows 10, Version 1809
CMake: 3.17.2
Compiler: MSVC 2019, 16.6.2
Backend: crashpad, inproc
Commit: e966dd1

OS: Ubuntu 18.04.4 LTS
CMake: 3.17.3
Compiler: gcc 9.3.0
Backend: breakpad
Commit: e966dd1

@daxpedda
Copy link
Contributor

daxpedda commented Jun 19, 2020

I just tried it with e45af98 and it works even with crashpad on windows now.

@Swatinem
Copy link
Member

Either way, another thing we do need tests for ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants