fix(utils): Consider 429 responses in transports #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
reviewed
May 10, 2022
packages/utils/src/ratelimit.ts
Outdated
| @@ -43,9 +43,14 @@ export function isRateLimited(limits: RateLimits, category: string, now: number | |||
| */ | |||
| export function updateRateLimits( | |||
| limits: RateLimits, | |||
| headers: Record<string, string | null | undefined>, | |||
| newRateLimitParameters: { | |||
There was a problem hiding this comment.
Let's type this to be TransportMakeRequestResponse? Then we can just do a check against headers with an early return, otherwise we know the headers should be defined.
There was a problem hiding this comment.
I don't quite get what you mean with the early return.
Do you mean it like this:
if (!headers?.['x-sentry-rate-limits'] && !headers?.['retry-after'] && statusCode === 429) {
updatedRateLimits.all = now + 60 * 1000;
return;
}Not sure if that is cleaner...
There was a problem hiding this comment.
You know what - ignore me on the headers check. I guess the header items can be null anyway.
I would still use the TransportMakeRequestResponse type to make things consistent though.
AbhiPrasad
approved these changes
May 10, 2022
packages/utils/src/ratelimit.ts
Outdated
| now: number = Date.now(), | ||
| ): RateLimits { | ||
| const { statusCode, headers } = newRateLimitParameters; |
There was a problem hiding this comment.
nit: we can do the destructure in the args above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rate limiting by conforming to the rate limiting spec: https://develop.sentry.dev/sdk/rate-limiting/#stage-1-parse-response-headers
Ref: https://getsentry.atlassian.net/browse/WEB-908