-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bundles): Stop publishing CDN bundles on npm #4901
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This theoretically is enough but there is the temporary bundle copy section in prepack.ts
which we should remove as well. Additionally, the --skipBundleCopy
flag is used in WASM which we don't need any longer either.
Thank you! I knew I missed something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now! 👍
Exclude CDN bundles from being published on npm by including them in
.npmignore
.Ref: https://getsentry.atlassian.net/browse/WEB-674