Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bundles): Stop publishing CDN bundles on npm #4901

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented Apr 8, 2022

Exclude CDN bundles from being published on npm by including them in .npmignore.

Ref: https://getsentry.atlassian.net/browse/WEB-674

@lforst lforst requested a review from Lms24 April 8, 2022 11:08
@lforst lforst changed the base branch from master to 7.x April 8, 2022 11:08
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.07 KB (-0.37% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.28 KB (-0.51% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.77 KB (-0.46% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.67 KB (-0.52% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.05 KB (-0.82% 🔽)
@sentry/browser - Webpack (minified) 80.87 KB (-1.03% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.09 KB (-0.81% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.86 KB (-0.41% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.01 KB (-0.24% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.42 KB (-0.26% 🔽)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This theoretically is enough but there is the temporary bundle copy section in prepack.ts which we should remove as well. Additionally, the --skipBundleCopy flag is used in WASM which we don't need any longer either.

@lforst
Copy link
Member Author

lforst commented Apr 8, 2022

This theoretically is enough but there is the temporary bundle copy section in prepack.ts which we should remove as well. Additionally, the --skipBundleCopy flag is used in WASM which we don't need any longer either.

Thank you! I knew I missed something.

@lforst lforst requested a review from Lms24 April 8, 2022 11:56
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 👍

@Lms24 Lms24 changed the title build(bundles): Stop publishing CDN bundles on npm ref(build): Stop publishing CDN bundles on npm Apr 8, 2022
@lforst lforst changed the title ref(build): Stop publishing CDN bundles on npm build(bundles): Stop publishing CDN bundles on npm Apr 8, 2022
@lforst lforst merged commit 14bb9ac into 7.x Apr 8, 2022
@lforst lforst deleted the lforst-v7-stop-publishing-cdn-bundles-on-npm branch April 8, 2022 13:01
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants