ref(hub): Simplify getting hub from active domain #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
changed the title
size-limit report
|
kamilogorek
approved these changes
Feb 2, 2021
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hub.getActiveDomainwas factored out ofHub.getHubFromActiveDomainin #2820 so it could be used ingetDefaultSamplingContext, which no longer exists (as of #3210).This is a follow up to that PR, which reverts the original factoring-out, and also gets rid of an interface which is unused as a result.This is a follow up to that PR, which reverts the original factoring-out and deprecates both the factored-out function and an interface which will be unused once the deprecated function is removed.