fix: Normalise ANR debug image file paths if appRoot was supplied #14708
+30
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that biome fix was failing on some stuff in the `.nuxt` folder in E2E tests, so figured to add this as well (and while at it, also ensure it is cleaned).
The v9 branch should not push to the v8 layer.
nitrojs/nitro#2703 fixed --------- Co-authored-by: Sigrid Huemer <[email protected]>
…w versions (#14707) temporarily disables publishing a lambda layer while `develop` is the branch where we cut v9 pre releases from. We shouldn't publish prerelease layer versions since we can't mark these layers as pre-release. They'd appear simply as stable new layer versions (with incremented ARN number)
lforst
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should normalise all paths in ANR events if an appRoot path is supplied. This is important for the Electron SDK where we normalise around the app path to keep usernames out of reported events.