Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nestjs): Exception filters in main app module are not being executed #13278

Merged
merged 36 commits into from
Aug 13, 2024

Conversation

nicohrubec
Copy link
Contributor

@nicohrubec nicohrubec commented Aug 8, 2024

ref

This PR moves the SentryGlobalFilter out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring:

  • If users have no catch-all exception filter in their application they add the SentryGlobalFilter as a provider in their main module.
  • If users have a catch-all exception filter (annotated with @Catch() they can use the newly introduced SentryCaptureException() decorator to capture alle exceptions caught by this filter.

Testing:
Added a new sample application to test the second setup option and expanded the test suite in general.

Side note:

  • Also removed the @sentry/microservices dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

@nicohrubec nicohrubec self-assigned this Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
@sentry/browser 22.5 KB (0%)
@sentry/browser (incl. Tracing) 34.85 KB (0%)
@sentry/browser (incl. Tracing, Replay) 71.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 64.45 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.53 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 88.17 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90 KB (0%)
@sentry/browser (incl. metrics) 26.81 KB (0%)
@sentry/browser (incl. Feedback) 39.47 KB (0%)
@sentry/browser (incl. sendFeedback) 27.13 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.79 KB (0%)
@sentry/react 25.26 KB (0%)
@sentry/react (incl. Tracing) 37.83 KB (0%)
@sentry/vue 26.65 KB (0%)
@sentry/vue (incl. Tracing) 36.67 KB (0%)
@sentry/svelte 22.64 KB (0%)
CDN Bundle 23.73 KB (0%)
CDN Bundle (incl. Tracing) 36.49 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.81 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.06 KB (0%)
CDN Bundle - uncompressed 69.61 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 108.27 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.52 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 232.41 KB (0%)
@sentry/nextjs (client) 37.59 KB (0%)
@sentry/sveltekit (client) 35.45 KB (0%)
@sentry/node 115.61 KB (0%)
@sentry/node - without tracing 90 KB (0%)
@sentry/aws-serverless 99.42 KB (0%)

@wodCZ
Copy link

wodCZ commented Aug 12, 2024

Feel free to ping me if you'd like testers for this. I have two NestJS projects in production running on various setups:

  • NestJS + Fastify + Mercurius GraphQL driver (this one breaks a lot with recent @sentry/node or @sentry/nestjs, something about res.reply not being a function when any error happens)
  • NestJS + Express + TsRest Nest (this one works quite fine with recent releases)

Thank you for pushing the NestJS integration forward, very much appreciated ❤️

@nicohrubec nicohrubec marked this pull request as ready for review August 12, 2024 11:11
@nicohrubec nicohrubec requested review from a team, stephanie-anderson and s1gr1d and removed request for a team August 12, 2024 11:12
@nicohrubec nicohrubec marked this pull request as ready for review August 13, 2024 13:49
*
* @returns `true` if the exception is expected and should not be reported to Sentry, otherwise `false`.
*/
export function isExpectedError(exception: unknown): boolean {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Rename to isProbablyNestjsHttpException()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's a good name because it's already responsible for filtering both RpcExceptions and HttpExceptions and maybe others in the future so should be a more general name

* This hooks into the @Injectable decorator, which is applied on class middleware, interceptors and guards.
* This hooks into
* 1. @Injectable decorator, which is applied on class middleware, interceptors and guards.
* 2. @Catch decorator, which is applied on exception filters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is left over I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I forgot to update that comment when I added the exception filter tracing so that's fine

@nicohrubec
Copy link
Contributor Author

@wodCZ Thanks for offering to help with testing! I'll be merging this PR now to fix some issues we are seeing with the nest SDK and also the dependency on @nestjs/microservices is resolved then. If you have time to test it in your apps either directly on develop or with the next release that would be amazing. If you find anything let us know and we will fix it :)

@nicohrubec nicohrubec merged commit 51ef02d into develop Aug 13, 2024
129 checks passed
@nicohrubec nicohrubec deleted the nh/nest-global-filter-test branch August 13, 2024 15:31
Zen-cronic pushed a commit to Zen-cronic/sentry-javascript that referenced this pull request Aug 26, 2024
…ted (getsentry#13278)

[ref](getsentry#12351)

This PR moves the `SentryGlobalFilter` out of the root module, which led
to the filter overriding user exception filters in certain scenarios.
Now there is two ways to setup sentry error monitoring:
- If users have no catch-all exception filter in their application they
add the `SentryGlobalFilter` as a provider in their main module.
- If users have a catch-all exception filter (annotated with `@Catch()`
they can use the newly introduced `SentryCaptureException()` decorator
to capture alle exceptions caught by this filter.

Testing:
Added a new sample application to test the second setup option and
expanded the test suite in general.

Side note:
- Also removed the `@sentry/microservices` dependency again, since it
does not come out of the box with every nest application so we cannot
rely on it.
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Sep 12, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.26.0` -> `8.30.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.26.0/8.30.0) |
| [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.26.0` -> `8.30.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.26.0/8.30.0) |

---

### Release Notes

<details>
<summary>getsentry/sentry-javascript (@&#8203;sentry/node)</summary>

### [`v8.30.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8300)

[Compare Source](getsentry/sentry-javascript@8.29.0...8.30.0)

##### Important Changes

-   *feat(node): Add `kafkajs` integration ([#&#8203;13528](getsentry/sentry-javascript#13528

This release adds a new integration that instruments `kafkajs` library with spans and traces. This integration is
automatically enabled by default, but can be included with the `Sentry.kafkaIntegration()` import.

```js
Sentry.init({
  integrations: [Sentry.kafkaIntegration()],
});
```

##### Other Changes

-   feat(core): Allow adding measurements without global client ([#&#8203;13612](getsentry/sentry-javascript#13612))
-   feat(deps): Bump [@&#8203;opentelemetry/instrumentation-undici](https://github.com/opentelemetry/instrumentation-undici) from 0.5.0 to 0.6.0 ([#&#8203;13622](getsentry/sentry-javascript#13622))
-   feat(deps): Bump [@&#8203;sentry/cli](https://github.com/sentry/cli) from 2.33.0 to 2.35.0 ([#&#8203;13624](getsentry/sentry-javascript#13624))
-   feat(node): Use `@opentelemetry/instrumentation-undici` for fetch tracing ([#&#8203;13485](getsentry/sentry-javascript#13485))
-   feat(nuxt): Add server config to root folder ([#&#8203;13583](getsentry/sentry-javascript#13583))
-   feat(otel): Upgrade [@&#8203;opentelemetry/semantic-conventions](https://github.com/opentelemetry/semantic-conventions) to 1.26.0 ([#&#8203;13631](getsentry/sentry-javascript#13631))
-   fix(browser): check supportedEntryTypes before caling the function ([#&#8203;13541](getsentry/sentry-javascript#13541))
-   fix(browser): Ensure Standalone CLS span timestamps are correct ([#&#8203;13649](getsentry/sentry-javascript#13649))
-   fix(nextjs): Widen removal of 404 transactions ([#&#8203;13628](getsentry/sentry-javascript#13628))
-   fix(node): Remove ambiguity and race conditions when matching local variables to exceptions ([#&#8203;13501](getsentry/sentry-javascript#13501))
-   fix(node): Update OpenTelemetry instrumentation package for solidstart and opentelemetry ([#&#8203;13640](getsentry/sentry-javascript#13640))
-   fix(node): Update OpenTelemetry instrumentation package for solidstart and opentelemetry ([#&#8203;13642](getsentry/sentry-javascript#13642))
-   fix(vue): Ensure Vue `trackComponents` list matches components with or without `<>` ([#&#8203;13543](getsentry/sentry-javascript#13543))
-   ref(profiling): Conditionally shim cjs globals ([#&#8203;13267](getsentry/sentry-javascript#13267))

Work in this release was contributed by [@&#8203;Zen-cronic](https://github.com/Zen-cronic) and [@&#8203;odanado](https://github.com/odanado). Thank you for your contributions!

### [`v8.29.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8290)

[Compare Source](getsentry/sentry-javascript@8.28.0...8.29.0)

##### Important Changes

-   **Beta releases of official Solid and SolidStart Sentry SDKs**

This release marks the beta releases of the `@sentry/solid` and `@sentry/solidstart` Sentry SDKs. For details on how to
use them, check out the
[Sentry Solid SDK README](https://github.com/getsentry/sentry-javascript/tree/develop/packages/solid) and the
[Sentry SolidStart SDK README](https://github.com/getsentry/sentry-javascript/tree/develop/packages/solidstart)
respectively. Please reach out on [GitHub](https://github.com/getsentry/sentry-javascript/issues/new/choose) if you have
any feedback or concerns.

-   **feat(node): Option to only wrap instrumented modules ([#&#8203;13139](getsentry/sentry-javascript#13139

Adds the SDK option to only wrap ES modules with `import-in-the-middle` that specifically need to be instrumented.

```javascript
import * as Sentry from '@&#8203;sentry/node';

Sentry.init({
  dsn: '__PUBLIC_DSN__',
  registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true },
});
```

-   **feat(node): Update OpenTelemetry packages to instrumentation v0.53.0 ([#&#8203;13587](getsentry/sentry-javascript#13587

All internal OpenTelemetry instrumentation was updated to their latest version. This adds support for Mongoose v7 and v8
and fixes various bugs related to ESM mode.

##### Other Changes

-   feat(nextjs): Emit warning when using turbopack ([#&#8203;13566](getsentry/sentry-javascript#13566))
-   feat(nextjs): Future-proof Next.js config options overriding ([#&#8203;13586](getsentry/sentry-javascript#13586))
-   feat(node): Add `generic-pool` integration ([#&#8203;13465](getsentry/sentry-javascript#13465))
-   feat(nuxt): Upload sourcemaps generated by Nitro ([#&#8203;13382](getsentry/sentry-javascript#13382))
-   feat(solidstart): Add `browserTracingIntegration` by default ([#&#8203;13561](getsentry/sentry-javascript#13561))
-   feat(solidstart): Add `sentrySolidStartVite` plugin to simplify source maps upload ([#&#8203;13493](getsentry/sentry-javascript#13493))
-   feat(vue): Only start UI spans if parent is available ([#&#8203;13568](getsentry/sentry-javascript#13568))
-   fix(cloudflare): Guard `context.waitUntil` call in request handler ([#&#8203;13549](getsentry/sentry-javascript#13549))
-   fix(gatsby): Fix assets path for sourcemaps upload ([#&#8203;13592](getsentry/sentry-javascript#13592))
-   fix(nextjs): Use posix paths for sourcemap uploads ([#&#8203;13603](getsentry/sentry-javascript#13603))
-   fix(node-fetch): Use stringified origin url ([#&#8203;13581](getsentry/sentry-javascript#13581))
-   fix(node): Replace dashes in `generic-pool` span origins with underscores ([#&#8203;13579](getsentry/sentry-javascript#13579))
-   fix(replay): Fix types in WebVitalData ([#&#8203;13573](getsentry/sentry-javascript#13573))
-   fix(replay): Improve replay web vital types ([#&#8203;13602](getsentry/sentry-javascript#13602))
-   fix(utils): Keep logger on carrier ([#&#8203;13570](getsentry/sentry-javascript#13570))

Work in this release was contributed by [@&#8203;Zen-cronic](https://github.com/Zen-cronic). Thank you for your contribution!

### [`v8.28.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8280)

[Compare Source](getsentry/sentry-javascript@8.27.0...8.28.0)

##### Important Changes

-   **Beta release of official NestJS SDK**

This release contains the beta version of `@sentry/nestjs`! For details on how to use it, check out the
[README](https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md). Any feedback/bug reports
are greatly appreciated, please reach out on GitHub.

-   **fix(browser): Remove faulty LCP, FCP and FP normalization logic ([#&#8203;13502](getsentry/sentry-javascript#13502

This release fixes a bug in the `@sentry/browser` package and all SDKs depending on this package (e.g. `@sentry/react`
or `@sentry/nextjs`) that caused the SDK to send incorrect web vital values for the LCP, FCP and FP vitals. The SDK
previously incorrectly processed the original values as they were reported from the browser. When updating your SDK to
this version, you might experience an increase in LCP, FCP and FP values, which potentially leads to a decrease in your
performance score in the Web Vitals Insights module in Sentry. This is because the previously reported values were
smaller than the actually measured values. We apologize for the inconvenience!

##### Other Changes

-   feat(nestjs): Add `SentryGlobalGraphQLFilter` ([#&#8203;13545](getsentry/sentry-javascript#13545))
-   feat(nestjs): Automatic instrumentation of nestjs interceptors after route execution ([#&#8203;13264](getsentry/sentry-javascript#13264))
-   feat(nextjs): Add `bundleSizeOptimizations` to build options ([#&#8203;13323](getsentry/sentry-javascript#13323))
-   feat(nextjs): Stabilize `captureRequestError` ([#&#8203;13550](getsentry/sentry-javascript#13550))
-   feat(nuxt): Wrap config in nuxt context ([#&#8203;13457](getsentry/sentry-javascript#13457))
-   feat(profiling): Expose profiler as top level primitive ([#&#8203;13512](getsentry/sentry-javascript#13512))
-   feat(replay): Add layout shift to CLS replay data ([#&#8203;13386](getsentry/sentry-javascript#13386))
-   feat(replay): Upgrade rrweb packages to 2.26.0 ([#&#8203;13483](getsentry/sentry-javascript#13483))
-   fix(cdn): Do not mangle \_metadata ([#&#8203;13426](getsentry/sentry-javascript#13426))
-   fix(cdn): Fix SDK source for CDN bundles ([#&#8203;13475](getsentry/sentry-javascript#13475))
-   fix(nestjs): Check arguments before instrumenting with `@Injectable` ([#&#8203;13544](getsentry/sentry-javascript#13544))
-   fix(nestjs): Ensure exception and host are correctly passed on when using [@&#8203;WithSentry](https://github.com/WithSentry) ([#&#8203;13564](getsentry/sentry-javascript#13564))
-   fix(node): Suppress tracing for transport request execution rather than transport creation ([#&#8203;13491](getsentry/sentry-javascript#13491))
-   fix(replay): Consider more things as DOM mutations for dead clicks ([#&#8203;13518](getsentry/sentry-javascript#13518))
-   fix(vue): Correctly obtain component name ([#&#8203;13484](getsentry/sentry-javascript#13484))

Work in this release was contributed by [@&#8203;leopoldkristjansson](https://github.com/leopoldkristjansson), [@&#8203;mhuggins](https://github.com/mhuggins) and [@&#8203;filips123](https://github.com/filips123). Thank you for your
contributions!

### [`v8.27.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8270)

[Compare Source](getsentry/sentry-javascript@8.26.0...8.27.0)

##### Important Changes

-   **fix(nestjs): Exception filters in main app module are not being executed ([#&#8203;13278](getsentry/sentry-javascript#13278

    With this release nestjs error monitoring is no longer automatically set up after adding the `SentryModule` to your
    application, which led to issues in certain scenarios. You will now have to either add the `SentryGlobalFilter` to
    your main module providers or decorate the `catch()` method in your existing global exception filters with the newly
    released `@WithSentry()` decorator. See the [docs](https://docs.sentry.io/platforms/javascript/guides/nestjs/) for
    more details.

##### Other Changes

-   feat: Add options for passing nonces to feedback integration ([#&#8203;13347](getsentry/sentry-javascript#13347))
-   feat: Add support for SENTRY_SPOTLIGHT env var in Node ([#&#8203;13325](getsentry/sentry-javascript#13325))
-   feat(deps): bump [@&#8203;prisma/instrumentation](https://github.com/prisma/instrumentation) from 5.17.0 to 5.18.0 ([#&#8203;13327](getsentry/sentry-javascript#13327))
-   feat(feedback): Improve error message for 403 errors ([#&#8203;13441](getsentry/sentry-javascript#13441))
-   fix(deno): Don't rely on `Deno.permissions.querySync` ([#&#8203;13378](getsentry/sentry-javascript#13378))
-   fix(replay): Ensure we publish replay CDN bundles ([#&#8203;13437](getsentry/sentry-javascript#13437))

Work in this release was contributed by [@&#8203;charpeni](https://github.com/charpeni). Thank you for your contribution!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41NS4zIiwidXBkYXRlZEluVmVyIjoiMzguNzMuNyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/61
Reviewed-by: Alexandre Soro <[email protected]>
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
vjousse pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Oct 1, 2024
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)


<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **1 version** ahead of your current
version.

- The recommended version was released on **25 days ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>@sentry/browser</b></summary>
    <ul>
      <li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
      </li>
      <li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
      </li>
    </ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'

Co-authored-by: snyk-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants