Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.JS SDK Crons to be Opt-in #8701

Closed
gaprl opened this issue Aug 1, 2023 · 4 comments · Fixed by #9697
Closed

Update Next.JS SDK Crons to be Opt-in #8701

gaprl opened this issue Aug 1, 2023 · 4 comments · Fixed by #9697

Comments

@gaprl
Copy link
Member

gaprl commented Aug 1, 2023

Currently, instrumentation for Crons monitors for our Next.JS is automatic. However, in preparations for GA and to enable billing, we should update this behavior to be opt-in instead, in a similar manner to our Celery Beat integration.

Otherwise, customers might face situations where we unintentionally bill them for Crons.

@AbhiPrasad AbhiPrasad self-assigned this Aug 2, 2023
@AbhiPrasad
Copy link
Member

Right now this is gated behind a flag automaticVercelMonitors, which defaults to true.

// next.config.js
const nextConfig = {
  sentry: {
    automaticVercelMonitors: false,
  },
};

If we move ahead with making this false by default, maybe we need to introduce another option that controls what routes get instrumented. @lforst your thoughts?

@lforst
Copy link
Member

lforst commented Aug 3, 2023

My thoughts:

  • If people have monitors and we switch the default, their monitors will miss and create issues - which would be annoying for them.
  • Billing situation sucks, however, in Next.js we also turn on performance monitoring by default which seems very analogous to me.

Considering the points above I would contemplate keeping the functionality as-is.

@AbhiPrasad
Copy link
Member

@lforst it's not like we turn it on by default - we explicitly add a tracesSampleRate when generating a Sentry.init. Right now that is completely opaque to users.

Since crons is a beta product, I think it's reasonable to turn it off. @gaprl maybe we can add some in product helpers that guide people toward this? (like hey you've upgraded to the most recent Next SDK version, update your config).

@AbhiPrasad AbhiPrasad removed their assignment Aug 10, 2023
@stephanie-anderson
Copy link
Contributor

On December 11th, billing will be turned on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants