Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize http.response.status_code for Metrics & Alerts #8692

Closed
Tracked by #9
AbhiPrasad opened this issue Aug 1, 2023 · 3 comments
Closed
Tracked by #9

Normalize http.response.status_code for Metrics & Alerts #8692

AbhiPrasad opened this issue Aug 1, 2023 · 3 comments

Comments

@AbhiPrasad
Copy link
Member

Problem Statement

ref #8365
team issue getsentry/team-sdks#9

Add status code to transactions under contexts.response.status_code

Response context: https://github.com/getsentry/relay/blob/master/relay-general/src/protocol/contexts/response.rs

Solution Brainstorm

Add context on transaction.finish

Add types for response context

@stephanie-anderson stephanie-anderson changed the title Add status code to transaction response context Normalize http.response.status_code for Metrics & Alerts Sep 11, 2023
@mydea
Copy link
Member

mydea commented Oct 3, 2023

Just to clarify, this is not fixed by #8366, but in addition to that we also want to set the status code in the transaction context?

@AbhiPrasad
Copy link
Member Author

Yes, because transactions don't have data applied to them.

@mydea
Copy link
Member

mydea commented Dec 10, 2024

This PR: #14634 should fix this - at least for transactions, we do not need to care about metrics there I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants