Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

429 Error - Existing Issue: "ignoreSentryErrors" option not available for latest release (version 7.1.1) #5270

Closed
davidlee0602 opened this issue Jun 16, 2022 · 1 comment

Comments

@davidlee0602
Copy link

davidlee0602 commented Jun 16, 2022

Problem Statement

Following a previous issue raised by other members: #4582

Summary:
429 errors (hard cap on rate limit in sentry config / settings) would prevent the AWS lambda function from running successfully, even though the error is a sentry internal error and not an error that generated from the logic of the AWS lambda function itself.

To prevent 429 errors from stopping lambda function execution, the following fix was applied to versions 6.18 and above;
#4620
however, it seems to have not been excluded in versions 7.0.0 and above (not included in latest Sentry release).

Can this ignoreSentryErrors option be included in the latest versions (7.x.x and above) of the repo?

Please kindly review and advise :)

Solution Brainstorm

Apply #4620 fix into latest / future releases :)

@davidlee0602 davidlee0602 changed the title 429 Error - Existing Issue: "ignoreSentryErrors" option not available for latest release (version 7.1.1) 429 Error - Existing Issue: "ignoreSentryErrors" option not available for latest release (version 7.x.x) Jun 16, 2022
@davidlee0602 davidlee0602 changed the title 429 Error - Existing Issue: "ignoreSentryErrors" option not available for latest release (version 7.x.x) 429 Error - Existing Issue: "ignoreSentryErrors" option not available for latest release (version 7.1.1) Jun 16, 2022
@lforst
Copy link
Member

lforst commented Jun 17, 2022

Hi @davidlee0602, thanks for writing in. We generally don't want the SDK to throw ever, so we fixed the underlying issue, namely errors bubbling up while sending error events to Sentry in #5090. This change made the ignoreSentryErrors options redundant so we removed it in v7.

Please see corresponding entries in our changelog and migration docs.

I will mark this issue as resolved, however, if issues because of non-2xx responses come up again in current or future versions, feel free to ping us here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants