Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New integration tests for @sentry/node #4260

Closed
22 tasks
AbhiPrasad opened this issue Dec 10, 2021 · 3 comments · Fixed by #4694
Closed
22 tasks

New integration tests for @sentry/node #4260

AbhiPrasad opened this issue Dec 10, 2021 · 3 comments · Fixed by #4694
Assignees
@onurtemizkan
Labels
Package: node Issues related to the Sentry Node SDK Type: Tests
Milestone
Release Stability

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Dec 10, 2021 •
edited
Loading

Let's figure out how to best test @sentry/node.

Our existing setup (running node scripts and asserting on the process): https://github.com/getsentry/sentry-javascript/tree/master/packages/node/test/manual

@onurtemizkan fyi if you have any feedback.

List of things that need to be tested:

Public API tests

  • addBreadcrumb
  • captureException
  • captureMessage
  • configureScope
  • setContext
  • setExtra
  • setExtras
  • setTag
  • setTags
  • setUser
  • withScope
  • showReportDialog
  • flush

Performance

  • startTransaction
  • Node Database Auto-instrumentation
    • Mongo
    • MySQL
    • Postgres

Sessions

Express

  • Errors
  • Performance

Koa

  • Errors
  • Performance
@AbhiPrasad AbhiPrasad added Package: node Issues related to the Sentry Node SDK Status: Backlog Type: Tests labels Dec 10, 2021
@AbhiPrasad AbhiPrasad added this to the Release Stability milestone Dec 10, 2021
@AbhiPrasad
Copy link
Member Author

This will help unblock #3961

@AbhiPrasad AbhiPrasad mentioned this issue Feb 11, 2022
Closed
@AbhiPrasad
Copy link
Member Author

We'll need to make sure we can integration test changes like #4563

@onurtemizkan onurtemizkan self-assigned this Feb 21, 2022
@onurtemizkan onurtemizkan mentioned this issue Mar 8, 2022
Merged
@AbhiPrasad AbhiPrasad mentioned this issue Mar 23, 2022
Closed
19 tasks
@AbhiPrasad
Copy link
Member Author

Transferred tracking individual integration tests in #4762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurtemizkan onurtemizkan

Labels
Package: node Issues related to the Sentry Node SDK Type: Tests
Projects
None yet
Milestone
Release Stability
Development

Successfully merging a pull request may close this issue.

test(node): Add Node SDK integration test structure. getsentry/sentry-javascript
2 participants
@onurtemizkan @AbhiPrasad