shouldSendCallback() not working

[jaimefps]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

^5.6.2

Description

I'm trying to leverage shouldSendCallback and dataCallback, but nothing get's logged when I forcefully throw errors. However, beforeSend does log the event when the forced errors occur.

So I am confused why beforeSend method works with console.log(), but the other two do not.

I've been using Sentry for a few months and everything has worked fine, it is only now with the two methods mentioned above that I cannot seem to get them to log anything for me to confirm they are working.

My config:

{
  dsn: '<my_dsn>',
  release: process.env.RELEASE,
  environment: process.env.NODE_ENV

  // not working
  shouldSendCallback(data) {
    console.log('data1:', data);
    return true;
  },

  // not working
  dataCallback(data) {
    console.log('data2:', data);
    return data;
  },

  // working fine
  beforeSend(event) {
    console.log('event:', event)
    return event;
  },

[kamilogorek]

There's no such thing as shouldSendCallback or dataCallback in @sentry/browser. It's the old API of raven-js package.

[jaimefps]

@kamilogorek I see, is beforeSend() the correct way of ignoring an alert?
I noticed that returning null makes it so that no alert is found in Sentry dashboard.

[kamilogorek]

That is correct. https://docs.sentry.io/error-reporting/configuration/filtering/?platform=browser

[Phil-Barber]

This page needs updating: https://help.sentry.io/account/billing/do-ignored-events-in-the-ui-count-towards-my-quota/

And this is an updated link to before_send https://docs.sentry.io/platforms/python/configuration/options/#before-send

[kamilogorek]

Thanks, updated https://github.com/getsentry/static-sites/pull/406