Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send LCP & CLS as standalone spans #12714

Open
mydea opened this issue Jul 1, 2024 · 1 comment
Open

Send LCP & CLS as standalone spans #12714

mydea opened this issue Jul 1, 2024 · 1 comment
Assignees
Labels
Feature: Spans Migrated Package: browser Issues related to the Sentry Browser SDK

Comments

@mydea
Copy link
Member

mydea commented Jul 1, 2024

Today, we send INP via a standalone span, to ensure it is captured correctly even if a transaction is not ongoing.

We should do the same for LCP and CLS. (Not sure about others? I guess these are the most relevant ones for this?)

This way, we may also be able to get rid of the "report all changes" code, and we can really only report the final value.

Open questions

  • What do we need to change for ingest to make this happen?
  • What should the exact span shape be?
  • Which web-vitals should be sent standalone - CLS, LCP, INP, what about the others?
  • Are there any other blockers to get rid of reportAllChanges?
  • This is not backwards compatible, it will require a certain version of self-hosted I guess. Do we care about this?
@mydea mydea added Feature: Spans Package: browser Issues related to the Sentry Browser SDK labels Jul 1, 2024
@cleptric
Copy link
Member

cleptric commented Jul 9, 2024

Some numbers from SaaS that highlight the potential of collecting more signals.

Firefox 2024-07-09 21 58 22

19.55M page load transactions / 90 days
15.90M FCP measurements / 90days
10.95M CLS measurements / 90 days
10.52M LCP measurements / 90 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Spans Migrated Package: browser Issues related to the Sentry Browser SDK
Projects
None yet
Development

No branches or pull requests

3 participants