-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set user agent span attribute on standalone spans #12689
Comments
@jjbayer @edwardgou-sentry we tested if setting |
Did you test on an AM3 plan org? There was another issue with standalone span ingestion on AM3 plans that we just found and fixed today: https://github.com/getsentry/getsentry/pull/14570
👍 sounds good to me! |
As discussed yesterday with @jjbayer I opened getsentry/relay#3815 to track the Relay changes. |
👍 |
@Lms24 @mydea for events, we also try to extract the browser name from client hints, should we do the same for spans? Any idea if there's an OTel convention for client hints attributes? |
@jjbayer there is https://opentelemetry.io/docs/specs/semconv/resource/browser/ which specifies some stuff that should be taken from the client hints, is that would you're thinking about? |
Update: I tested this change with a NextJS up using |
While investigating #11646, we found the root of the problem:
INP ingestion depends on the user agent (because it differs by browser). When using a tunnel the user-agent may often not be forwarded, leading to INP not being measured correctly.
We should fix this server-side by not ignoring INP spans without a user agent, but we should also add the user agent as an attribute to these spans so they can be used (if set) to improve handling.
Based on https://opentelemetry.io/docs/specs/semconv/attributes-registry/user-agent/, we should set
user_agent.original
to the full user agent string.The text was updated successfully, but these errors were encountered: