fix(nextjs): Only delete clientside bundle source maps with `sourcema…

…ps.deleteFilesAfterUpload` (#13102)
getsentry · Jul 30, 2024 · ce53667 · ce53667
1 parent e3af1ce
commit ce53667
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-app-dir/assert-build.ts b/dev-packages/e2e-tests/test-applications/nextjs-app-dir/assert-build.ts
@@ -22,10 +22,10 @@ assert.match(buildStdout, /(λ|ƒ) \/server-component\/parameter\/\[\.\.\.parame
 assert.match(buildStdout, /(λ|ƒ) \/server-component\/parameter\/\[parameter\]/);
 
 // Read the contents of the directory
-const files = fs.readdirSync(path.join(process.cwd(), '.next', 'server'));
+const files = fs.readdirSync(path.join(process.cwd(), '.next', 'static'));
 const mapFiles = files.filter(file => path.extname(file) === '.map');
 if (mapFiles.length > 0) {
-  throw new Error('.map files found even though `sourcemaps.deleteSourcemapsAfterUpload` option is set!');
+  throw new Error('Client bundle .map files found even though `sourcemaps.deleteSourcemapsAfterUpload` option is set!');
 }
 
 export {};
diff --git a/packages/nextjs/src/config/webpackPluginOptions.ts b/packages/nextjs/src/config/webpackPluginOptions.ts
@@ -76,9 +76,12 @@ export function getWebpackPluginOptions(
       ignore: sentryBuildOptions.sourcemaps?.ignore ?? sourcemapUploadIgnore,
       filesToDeleteAfterUpload: sentryBuildOptions.sourcemaps?.deleteSourcemapsAfterUpload
         ? [
-            path.join(distDirAbsPath, '**', '*.js.map'),
-            path.join(distDirAbsPath, '**', '*.mjs.map'),
-            path.join(distDirAbsPath, '**', '*.cjs.map'),
+            // We only care to delete client bundle source maps because they would be the ones being served.
+            // Removing the server source maps crashes Vercel builds for (thus far) unknown reasons:
+            // https://github.com/getsentry/sentry-javascript/issues/13099
+            path.join(distDirAbsPath, 'static', '**', '*.js.map'),
+            path.join(distDirAbsPath, 'static', '**', '*.mjs.map'),
+            path.join(distDirAbsPath, 'static', '**', '*.cjs.map'),
           ]
         : undefined,
       ...sentryBuildOptions.unstable_sentryWebpackPluginOptions?.sourcemaps,