fix(node): Replace dashes in generic-pool span origins with undersc…

…ores (#13579) Ref #13465 (comment)
getsentry · Sep 4, 2024 · 50589cd · 50589cd
1 parent 6dc8aab
commit 50589cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/dev-packages/node-integration-tests/suites/tracing/genericPool/test.ts b/dev-packages/node-integration-tests/suites/tracing/genericPool/test.ts
@@ -11,18 +11,18 @@ describe('genericPool auto instrumentation', () => {
       spans: expect.arrayContaining([
         expect.objectContaining({
           description: expect.stringMatching(/^generic-pool\.ac?quire/),
-          origin: 'auto.db.otel.generic-pool',
+          origin: 'auto.db.otel.generic_pool',
           data: {
-            'sentry.origin': 'auto.db.otel.generic-pool',
+            'sentry.origin': 'auto.db.otel.generic_pool',
           },
           status: 'ok',
         }),
 
         expect.objectContaining({
           description: expect.stringMatching(/^generic-pool\.ac?quire/),
-          origin: 'auto.db.otel.generic-pool',
+          origin: 'auto.db.otel.generic_pool',
           data: {
-            'sentry.origin': 'auto.db.otel.generic-pool',
+            'sentry.origin': 'auto.db.otel.generic_pool',
           },
           status: 'ok',
         }),

diff --git a/packages/node/src/integrations/tracing/genericPool.ts b/packages/node/src/integrations/tracing/genericPool.ts
@@ -25,7 +25,7 @@ const _genericPoolIntegration = (() => {
           spanDescription === 'generic-pool.aquire' || spanDescription === 'generic-pool.acquire';
 
         if (isGenericPoolSpan) {
-          span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic-pool');
+          span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic_pool');
         }
       });
     },