From 4d779836285088887fd62adf98225a915b9dfed2 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Tue, 15 Feb 2022 09:52:27 -0800 Subject: [PATCH] chore(build): Update and hoist `rollup` (#4578) As prep for the new bundling process, this updates `rollup` to latest and hoists it to the main `package.json`. Other than single-character changes to generated variable names, the only effect this has on the generated bundles is to add `Object.defineProperty(exports, '__esModule', { value: true });` (or its minified counterpart) at the end of each bundle. According to the Rollup docs[1]: > This property signifies that the exported value is the namespace of an ES module and that the default export of this module corresponds to the .default property of the exported object. Since we don't have default exports from our SDKs or integrations, this isn't necessary and just adds dead weight to the bundles. Setting `output.esModule` to `false` in the Rollup config prevents this addition. [1] https://rollupjs.org/guide/en/#outputesmodule --- package.json | 1 + packages/browser/package.json | 1 - packages/browser/rollup.config.js | 1 + packages/integrations/package.json | 1 - packages/integrations/rollup.config.js | 1 + packages/tracing/package.json | 1 - packages/tracing/rollup.config.js | 1 + packages/vue/package.json | 1 - packages/vue/rollup.config.js | 1 + packages/wasm/package.json | 1 - packages/wasm/rollup.config.js | 1 + yarn.lock | 16 +++++++--------- 12 files changed, 13 insertions(+), 14 deletions(-) diff --git a/package.json b/package.json index 406eda4b5c67..22c3ff8a0402 100644 --- a/package.json +++ b/package.json @@ -72,6 +72,7 @@ "prettier": "2.5.1", "replace-in-file": "^4.0.0", "rimraf": "^3.0.2", + "rollup": "^2.67.1", "rollup-plugin-license": "^2.6.1", "rollup-plugin-terser": "^7.0.2", "rollup-plugin-typescript2": "^0.31.2", diff --git a/packages/browser/package.json b/packages/browser/package.json index fd37989b7605..dde759028e7a 100644 --- a/packages/browser/package.json +++ b/packages/browser/package.json @@ -40,7 +40,6 @@ "karma-webkit-launcher": "^1.0.2", "node-fetch": "^2.6.0", "playwright": "^1.17.1", - "rollup": "^1.10.1", "rollup-plugin-commonjs": "^9.3.4", "rollup-plugin-node-resolve": "^4.2.3", "sinon": "^7.3.2", diff --git a/packages/browser/rollup.config.js b/packages/browser/rollup.config.js index 40615730a55f..c0c26e51f58c 100644 --- a/packages/browser/rollup.config.js +++ b/packages/browser/rollup.config.js @@ -82,6 +82,7 @@ const bundleConfig = { name: 'Sentry', sourcemap: true, strict: false, + esModule: false, }, context: 'window', plugins: [ diff --git a/packages/integrations/package.json b/packages/integrations/package.json index e2838a10a413..7ef3db7fbd33 100644 --- a/packages/integrations/package.json +++ b/packages/integrations/package.json @@ -23,7 +23,6 @@ }, "devDependencies": { "chai": "^4.1.2", - "rollup": "^1.10.1", "rollup-plugin-commonjs": "^9.3.4", "rollup-plugin-node-resolve": "^4.2.3" }, diff --git a/packages/integrations/rollup.config.js b/packages/integrations/rollup.config.js index c74e2da01f32..80494c21473f 100644 --- a/packages/integrations/rollup.config.js +++ b/packages/integrations/rollup.config.js @@ -95,6 +95,7 @@ function loadAllIntegrations() { format: 'cjs', sourcemap: true, strict: false, + esModule: false, }, plugins: build.plugins, treeshake: 'smallest', diff --git a/packages/tracing/package.json b/packages/tracing/package.json index 03484e7a677e..82a67d4adbcf 100644 --- a/packages/tracing/package.json +++ b/packages/tracing/package.json @@ -27,7 +27,6 @@ "@types/express": "^4.17.1", "@types/jsdom": "^16.2.3", "jsdom": "^16.2.2", - "rollup": "^1.10.1", "rollup-plugin-commonjs": "^9.3.4", "rollup-plugin-node-resolve": "^4.2.3" }, diff --git a/packages/tracing/rollup.config.js b/packages/tracing/rollup.config.js index afdf18256cb9..571b973fb717 100644 --- a/packages/tracing/rollup.config.js +++ b/packages/tracing/rollup.config.js @@ -70,6 +70,7 @@ const bundleConfig = { name: 'Sentry', sourcemap: true, strict: false, + esModule: false, }, context: 'window', plugins: [ diff --git a/packages/vue/package.json b/packages/vue/package.json index 68fa9ee4c33f..95669cd1001a 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -29,7 +29,6 @@ }, "devDependencies": { "jsdom": "^16.2.2", - "rollup": "^1.10.1", "rollup-plugin-commonjs": "^9.3.4", "rollup-plugin-node-resolve": "^4.2.3" }, diff --git a/packages/vue/rollup.config.js b/packages/vue/rollup.config.js index 4f9e8e9e49fd..8cbb06c7f1e6 100644 --- a/packages/vue/rollup.config.js +++ b/packages/vue/rollup.config.js @@ -70,6 +70,7 @@ const bundleConfig = { name: 'Sentry', sourcemap: true, strict: false, + esModule: false, }, context: 'window', plugins: [ diff --git a/packages/wasm/package.json b/packages/wasm/package.json index 20d6a274c945..9735b4a627aa 100644 --- a/packages/wasm/package.json +++ b/packages/wasm/package.json @@ -27,7 +27,6 @@ "express": "^4.17.1", "jest-puppeteer": "^4.4.0", "puppeteer": "^5.5.0", - "rollup": "^1.10.1", "rollup-plugin-commonjs": "^9.3.4", "rollup-plugin-node-resolve": "^4.2.3" }, diff --git a/packages/wasm/rollup.config.js b/packages/wasm/rollup.config.js index 2efc7a34e1e6..1feea972a45f 100644 --- a/packages/wasm/rollup.config.js +++ b/packages/wasm/rollup.config.js @@ -88,6 +88,7 @@ function loadAllIntegrations() { format: 'cjs', sourcemap: true, strict: false, + esModule: false, }, plugins: build.plugins, treeshake: 'smallest', diff --git a/yarn.lock b/yarn.lock index 41816a01776f..96e21781e46b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -11231,7 +11231,7 @@ fsevents@^1.2.7: bindings "^1.5.0" nan "^2.12.1" -fsevents@~2.3.1: +fsevents@~2.3.1, fsevents@~2.3.2: version "2.3.2" resolved "https://registry.yarnpkg.com/fsevents/-/fsevents-2.3.2.tgz#8a526f78b8fdf4623b709e0b975c52c24c02fd1a" integrity sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA== @@ -18972,14 +18972,12 @@ rollup-pluginutils@^2.6.0: dependencies: estree-walker "^0.6.1" -rollup@^1.10.1: - version "1.32.1" - resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.32.1.tgz#4480e52d9d9e2ae4b46ba0d9ddeaf3163940f9c4" - integrity sha512-/2HA0Ec70TvQnXdzynFffkjA6XN+1e2pEv/uKS5Ulca40g2L7KuOE3riasHoNVHOsFD5KKZgDsMk1CP3Tw9s+A== - dependencies: - "@types/estree" "*" - "@types/node" "*" - acorn "^7.1.0" +rollup@^2.67.1: + version "2.67.1" + resolved "https://registry.yarnpkg.com/rollup/-/rollup-2.67.1.tgz#4402665706fa00f321d446ce45f880e02cf54f01" + integrity sha512-1Sbcs4OuW+aD+hhqpIRl+RqooIpF6uQcfzU/QSI7vGkwADY6cM4iLsBGRM2CGLXDTDN5y/yShohFmnKegSPWzg== + optionalDependencies: + fsevents "~2.3.2" rsvp@^3.0.14, rsvp@^3.0.17, rsvp@^3.0.18, rsvp@^3.0.21, rsvp@^3.0.6, rsvp@^3.1.0: version "3.6.2"