From 2ae79fa34218166635e33a1d78a3dabbd095272e Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 4 Dec 2023 20:19:51 +0100 Subject: [PATCH] chore(feedback): Adjust package resolutions for `@sentry-internal/feedback` in Remix and NextJS Integration tests (#9733) --- docs/new-sdk-release-checklist.md | 2 ++ packages/nextjs/test/integration/package.json | 1 + packages/remix/test/integration/package.json | 1 + 3 files changed, 4 insertions(+) diff --git a/docs/new-sdk-release-checklist.md b/docs/new-sdk-release-checklist.md index c02f0d01c1ef..fc7cd8be3edf 100644 --- a/docs/new-sdk-release-checklist.md +++ b/docs/new-sdk-release-checklist.md @@ -49,6 +49,8 @@ This page serves as a checklist of what to do when releasing a new SDK for the f - [ ] Make sure it is added to the [Verdaccio config](https://github.com/getsentry/sentry-javascript/blob/develop/packages/e2e-tests/verdaccio-config/config.yaml) for the E2E tests +- [ ] If the package you're adding is a dependency of fullstack framework (e.g. Remix or NextJS) SDKs, make sure that your package is added to the integration test apps' `"resolutions"` field in their `package.json`s. + ## Cutting the Release When you’re ready to make the first release, there are a couple of steps that need to be performed in the **correct order**. Note that you can prepare the PRs at any time but the **merging oder** is important: diff --git a/packages/nextjs/test/integration/package.json b/packages/nextjs/test/integration/package.json index b62f4583e188..0bbe126a10b6 100644 --- a/packages/nextjs/test/integration/package.json +++ b/packages/nextjs/test/integration/package.json @@ -33,6 +33,7 @@ "@sentry/replay": "file:../../../replay", "@sentry/tracing": "file:../../../tracing", "@sentry-internal/tracing": "file:../../../tracing-internal", + "@sentry-internal/feedback": "file:../../../feedback", "@sentry/types": "file:../../../types", "@sentry/utils": "file:../../../utils", "@sentry/vercel-edge": "file:../../../vercel-edge" diff --git a/packages/remix/test/integration/package.json b/packages/remix/test/integration/package.json index f72262e64167..a4ad4f4e3423 100644 --- a/packages/remix/test/integration/package.json +++ b/packages/remix/test/integration/package.json @@ -31,6 +31,7 @@ "@sentry/replay": "file:../../../replay", "@sentry/tracing": "file:../../../tracing", "@sentry-internal/tracing": "file:../../../tracing-internal", + "@sentry-internal/feedback": "file:../../../feedback", "@sentry/types": "file:../../../types", "@sentry/utils": "file:../../../utils", "@vanilla-extract/css": "1.13.0"