Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics] Timing API race condition #3290

Closed
philipphofmann opened this issue Mar 28, 2024 · 0 comments
Closed

[Metrics] Timing API race condition #3290

philipphofmann opened this issue Mar 28, 2024 · 0 comments
Assignees

Comments

@philipphofmann
Copy link
Member

Description

If the hub's current span changes between these two calls, then LocalMetricsAggregator doesn't match the metric's started span.

final @Nullable LocalMetricsAggregator localMetricsAggregator =
aggregator.getLocalMetricsAggregator();
final @Nullable ISpan span = aggregator.startSpanForMetric("metric.timing", key);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants