Copy constructor of the Scope class doesn't copy contexts

[dmytrobabeshko]

Platform:

• Android -> If yes, which Device API (and compileSdkVersion/targetSdkVersion/Build tools) version?
• Java -> Liberica 11.0.12, level 11
• Kotlin -> If yes, which Kotlin (and jvmTarget) version?
• NDK -> If yes, which NDK/CMake version?
• React-Native -> If yes, which version?
• Timber -> If yes, which version?
• Log4j2 -> If yes, which version?
• Logback -> If yes, which version?
• Spring -> If yes, which version?

IDE:

• Android Studio -> If yes, which version?
• IntelliJ -> Build #IU-213.4631.20, built on October 6, 2021
• Other -> If yes, which one?

Build system:

• Gradle -> 7.2
• Buck -> If yes, which version?
• Bazel -> If yes, which version?
• Maven -> If yes, which version?
• Other -> If yes, which one?

Android Gradle Plugin:

• Yes -> If yes, which version?
• No

Sentry Android Gradle Plugin:

• Yes -> If yes, which version?
• No

Proguard/R8:

• Enabled
• Disabled

Platform installed with:

• JCenter
• Bintray
• Maven Central
• Manually

The version of the SDK:
5.2.1

---

When clonnig Sentry.getCurrentHub() and setting it to the current hub in the new thread scope.contexts is not copied and always empty.

Example code:

private @NotNull Runnable copyContext(@NotNull Runnable runnable) {
    final IHub oldState = Sentry.getCurrentHub();
    final IHub newHub = Sentry.getCurrentHub().clone();

    return () -> {
        try {
            Sentry.setCurrentHub(newHub);
            runnable.run();
        } finally {
            Sentry.setCurrentHub(oldState);
        }
    };
}

Root cause:
Looks like this is because of the issue in the copy constructor of the Scope class.

sentry-java/sentry/src/main/java/io/sentry/Scope.java

Line 133 in ff74a9e

this.contexts = new Contexts(contexts);

this.contexts and contexts are actually exactly the same this instance

Expected result:

• scope.contexts is copied to the new hub while cloning

[marandaneto]

@dmitrybabeshko thanks for raising, good catch, looks like it should be:

this.contexts = new Contexts(scope.contexts); instead.

@maciejwalkowiak mind having a look?

[maciejwalkowiak]

Fixed in #1763