-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use App Startup library instead of ContentProvider #1707
Comments
I'm not sure we can be adding a dependency to @marandaneto thoughts? |
yep, the problem is depending on the library, when you can always go for the manual init. https://docs.sentry.io/platforms/android/configuration/manual-init/ and remove the merging of the |
This is indeed a nice improvement. With the current setup, what would be the best way to initialize Sentry first? I'm thinking about increasing the initOrder of the content provider |
I'm not sure why we didn't set the priority, @marandaneto knows probably |
It is set, p2 |
I meant for the |
I tried that and it it indeed helps init Sentry provider a bit early. But if we have an app start crash in the next content providers, Sentry doesn't have time to upload the logs. See #1643 |
The |
Yes, but only one instead of N, that's the difference. |
Hey @kahest is there any progress on this? |
Quick update on this topic, as we recently discussed it. #1643 has been implemented for a while, meaning if the SDK detects and app start crash it will block execution (even on the main thread) to ensure there's enough time to send the crash report to sentry.io However, in the long run we plan to move away from using |
Thanks everyone for voting, this helps us re-priortize issues like this one! |
Could you please consider using
androidx.startup:startup-runtime
instead of ContentProvider introduced in #1487?Jetpack libraries (e.g. WorkManager) are migrating from ContentProvider to App Startup library in order to improve app startup performance and to achieve predictable order of initialization. It would be very nice if Sentry does the same.
Documentation: https://developer.android.com/topic/libraries/app-startup
The text was updated successfully, but these errors were encountered: