Scope clones the transaction but it should not

[marandaneto]

bug introduced in #1496

we have to confirm this behaviour but I am pretty sure it should not

[marandaneto]

@bruno-garcia can you confirm?

[bruno-garcia]

Looks like it's not cloning. It copies the reference thouhg:

    this.transaction = scope.transaction;

https://github.com/getsentry/sentry-java/pull/1496/files#diff-9cb115b44ee4c6940b189c33ba24e7b6a168271eefc02f6c0d6c053e75da94c5R83

I believe that's the right thing so that in a server if you push a scope, you can still find the transaction and create children.

[marandaneto]

before it was not copying even the reference, that was my point actually, the spec does not say if it should clone or copy the reference or be null, @rhcarvalho maybe?

[marandaneto]

copying the reference is also done by the .NET/Python SDK, so I'll close it.
https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/scope.py#L473