Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace clone() with copy constructor #1482

Closed
maciejwalkowiak opened this issue May 19, 2021 · 0 comments · Fixed by #1496
Closed

Replace clone() with copy constructor #1482

maciejwalkowiak opened this issue May 19, 2021 · 0 comments · Fixed by #1496
Labels
enhancement New feature or request

Comments

@maciejwalkowiak
Copy link
Contributor

For creating copy of objects we use clone method and Cloneable interfaces, which means we need to deal with the CloneNotSupportedExceptions and keep in mind the "magic" of the clone method. More about this topic in https://www.artima.com/articles/josh-bloch-on-design#part13 (section "Copy Constructor versus Cloning").

We could use instead copy constructors to simplify our code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace clone() with copy constructor getsentry/sentry-java
2 participants
@maciejwalkowiak @marandaneto