-
-
Notifications
You must be signed in to change notification settings - Fork 443
/
SentryOkHttpInterceptorTest.kt
587 lines (522 loc) · 21.2 KB
/
SentryOkHttpInterceptorTest.kt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
@file:Suppress("MaxLineLength")
package io.sentry.okhttp
import io.sentry.BaggageHeader
import io.sentry.Breadcrumb
import io.sentry.Hint
import io.sentry.HttpStatusCodeRange
import io.sentry.IHub
import io.sentry.IScope
import io.sentry.Scope
import io.sentry.ScopeCallback
import io.sentry.SentryOptions
import io.sentry.SentryTraceHeader
import io.sentry.SentryTracer
import io.sentry.SpanDataConvention
import io.sentry.SpanStatus
import io.sentry.TransactionContext
import io.sentry.TypeCheckHint
import io.sentry.exception.SentryHttpClientException
import okhttp3.Interceptor
import okhttp3.MediaType.Companion.toMediaType
import okhttp3.OkHttpClient
import okhttp3.Request
import okhttp3.RequestBody
import okhttp3.RequestBody.Companion.toRequestBody
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer
import okhttp3.mockwebserver.SocketPolicy
import org.mockito.kotlin.any
import org.mockito.kotlin.anyOrNull
import org.mockito.kotlin.check
import org.mockito.kotlin.doAnswer
import org.mockito.kotlin.mock
import org.mockito.kotlin.never
import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import java.io.IOException
import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertFalse
import kotlin.test.assertNotNull
import kotlin.test.assertNull
import kotlin.test.assertTrue
import kotlin.test.fail
class SentryOkHttpInterceptorTest {
class Fixture {
val hub = mock<IHub>()
val server = MockWebServer()
lateinit var sentryTracer: SentryTracer
lateinit var options: SentryOptions
lateinit var scope: IScope
@SuppressWarnings("LongParameterList")
fun getSut(
isSpanActive: Boolean = true,
httpStatusCode: Int = 201,
responseBody: String = "success",
socketPolicy: SocketPolicy = SocketPolicy.KEEP_OPEN,
beforeSpan: SentryOkHttpInterceptor.BeforeSpanCallback? = null,
includeMockServerInTracePropagationTargets: Boolean = true,
keepDefaultTracePropagationTargets: Boolean = false,
captureFailedRequests: Boolean? = false,
failedRequestTargets: List<String> = listOf(".*"),
failedRequestStatusCodes: List<HttpStatusCodeRange> = listOf(
HttpStatusCodeRange(
HttpStatusCodeRange.DEFAULT_MIN,
HttpStatusCodeRange.DEFAULT_MAX
)
),
sendDefaultPii: Boolean = false
): OkHttpClient {
options = SentryOptions().apply {
dsn = "https://[email protected]/proj"
if (includeMockServerInTracePropagationTargets) {
setTracePropagationTargets(listOf(server.hostName))
} else if (!keepDefaultTracePropagationTargets) {
setTracePropagationTargets(listOf("other-api"))
}
isSendDefaultPii = sendDefaultPii
}
scope = Scope(options)
whenever(hub.options).thenReturn(options)
doAnswer { (it.arguments[0] as ScopeCallback).run(scope) }.whenever(hub).configureScope(any())
sentryTracer = SentryTracer(TransactionContext("name", "op"), hub)
if (isSpanActive) {
whenever(hub.span).thenReturn(sentryTracer)
}
server.enqueue(
MockResponse()
.setBody(responseBody)
.addHeader("myResponseHeader", "myValue")
.setSocketPolicy(socketPolicy)
.setResponseCode(httpStatusCode)
)
val interceptor = when (captureFailedRequests) {
null -> SentryOkHttpInterceptor(
hub,
beforeSpan,
failedRequestTargets = failedRequestTargets,
failedRequestStatusCodes = failedRequestStatusCodes
)
else -> SentryOkHttpInterceptor(
hub,
beforeSpan,
captureFailedRequests = captureFailedRequests,
failedRequestTargets = failedRequestTargets,
failedRequestStatusCodes = failedRequestStatusCodes
)
}
return OkHttpClient.Builder().addInterceptor(interceptor).build()
}
}
private val fixture = Fixture()
private fun getRequest(url: String = "/hello"): Request {
return Request.Builder()
.addHeader("myHeader", "myValue")
.get()
.url(fixture.server.url(url))
.build()
}
private val getRequestWithBaggageHeader = {
Request.Builder()
.addHeader("baggage", "thirdPartyBaggage=someValue")
.addHeader(
"baggage",
"secondThirdPartyBaggage=secondValue; " +
"property;propertyKey=propertyValue,anotherThirdPartyBaggage=anotherValue"
)
.get()
.url(fixture.server.url("/hello"))
.build()
}
private fun postRequest(
body: RequestBody = "request-body"
.toRequestBody(
"text/plain"
.toMediaType()
)
): Request {
return Request.Builder().post(
body
).url(fixture.server.url("/hello")).build()
}
@SuppressWarnings("MaxLineLength")
@Test
fun `when there is an active span and server is listed in tracing origins, adds sentry trace headers to the request`() {
val sut = fixture.getSut()
sut.newCall(getRequest()).execute()
val recorderRequest = fixture.server.takeRequest()
assertNotNull(recorderRequest.headers[SentryTraceHeader.SENTRY_TRACE_HEADER])
assertNotNull(recorderRequest.headers[BaggageHeader.BAGGAGE_HEADER])
}
@SuppressWarnings("MaxLineLength")
@Test
fun `when there is an active span and tracing origins contains default regex, adds sentry trace headers to the request`() {
val sut = fixture.getSut(keepDefaultTracePropagationTargets = true)
sut.newCall(getRequest()).execute()
val recorderRequest = fixture.server.takeRequest()
assertNotNull(recorderRequest.headers[SentryTraceHeader.SENTRY_TRACE_HEADER])
assertNotNull(recorderRequest.headers[BaggageHeader.BAGGAGE_HEADER])
}
@SuppressWarnings("MaxLineLength")
@Test
fun `when there is an active span and server is not listed in tracing origins, does not add sentry trace headers to the request`() {
val sut = fixture.getSut(includeMockServerInTracePropagationTargets = false)
sut.newCall(Request.Builder().get().url(fixture.server.url("/hello")).build()).execute()
val recorderRequest = fixture.server.takeRequest()
assertNull(recorderRequest.headers[SentryTraceHeader.SENTRY_TRACE_HEADER])
assertNull(recorderRequest.headers[BaggageHeader.BAGGAGE_HEADER])
}
@SuppressWarnings("MaxLineLength")
@Test
fun `when there is an active span and server tracing origins is empty, does not add sentry trace headers to the request`() {
val sut = fixture.getSut()
fixture.options.setTracePropagationTargets(emptyList())
sut.newCall(Request.Builder().get().url(fixture.server.url("/hello")).build()).execute()
val recorderRequest = fixture.server.takeRequest()
assertNull(recorderRequest.headers[SentryTraceHeader.SENTRY_TRACE_HEADER])
assertNull(recorderRequest.headers[BaggageHeader.BAGGAGE_HEADER])
}
@Test
fun `when there is no active span, adds sentry trace header to the request from scope`() {
val sut = fixture.getSut(isSpanActive = false)
sut.newCall(getRequest()).execute()
val recorderRequest = fixture.server.takeRequest()
assertNotNull(recorderRequest.headers[SentryTraceHeader.SENTRY_TRACE_HEADER])
assertNotNull(recorderRequest.headers[BaggageHeader.BAGGAGE_HEADER])
}
@Test
fun `when there is no active span and host if not allowed, does not add sentry trace header to the request`() {
val sut = fixture.getSut(isSpanActive = false)
fixture.options.setTracePropagationTargets(listOf("some-host-that-does-not-exist"))
sut.newCall(getRequest()).execute()
val recorderRequest = fixture.server.takeRequest()
assertNull(recorderRequest.headers[SentryTraceHeader.SENTRY_TRACE_HEADER])
assertNull(recorderRequest.headers[BaggageHeader.BAGGAGE_HEADER])
}
@Test
fun `when there is an active span, existing baggage headers are merged with sentry baggage into single header`() {
val sut = fixture.getSut()
sut.newCall(getRequestWithBaggageHeader()).execute()
val recorderRequest = fixture.server.takeRequest()
assertNotNull(recorderRequest.headers[SentryTraceHeader.SENTRY_TRACE_HEADER])
assertNotNull(recorderRequest.headers[BaggageHeader.BAGGAGE_HEADER])
val baggageHeaderValues = recorderRequest.headers.values(BaggageHeader.BAGGAGE_HEADER)
assertEquals(baggageHeaderValues.size, 1)
assertTrue(
baggageHeaderValues[0].startsWith(
"thirdPartyBaggage=someValue," +
"secondThirdPartyBaggage=secondValue; " +
"property;propertyKey=propertyValue," +
"anotherThirdPartyBaggage=anotherValue"
)
)
assertTrue(baggageHeaderValues[0].contains("sentry-public_key=key"))
assertTrue(baggageHeaderValues[0].contains("sentry-transaction=name"))
assertTrue(baggageHeaderValues[0].contains("sentry-trace_id"))
}
@Test
fun `does not overwrite response body`() {
val sut = fixture.getSut()
val response = sut.newCall(getRequest()).execute()
assertEquals("success", response.body?.string())
}
@Test
fun `creates a span around the request`() {
val sut = fixture.getSut()
val request = getRequest()
sut.newCall(request).execute()
assertEquals(1, fixture.sentryTracer.children.size)
val httpClientSpan = fixture.sentryTracer.children.first()
assertEquals("http.client", httpClientSpan.operation)
assertEquals("GET ${request.url}", httpClientSpan.description)
assertEquals(201, httpClientSpan.data[SpanDataConvention.HTTP_STATUS_CODE_KEY])
assertEquals("auto.http.okhttp", httpClientSpan.spanContext.origin)
assertEquals(SpanStatus.OK, httpClientSpan.status)
assertTrue(httpClientSpan.isFinished)
}
@Test
fun `maps http status code to SpanStatus`() {
val sut = fixture.getSut(httpStatusCode = 400)
sut.newCall(getRequest()).execute()
val httpClientSpan = fixture.sentryTracer.children.first()
assertEquals(400, httpClientSpan.data[SpanDataConvention.HTTP_STATUS_CODE_KEY])
assertEquals(SpanStatus.INVALID_ARGUMENT, httpClientSpan.status)
}
@Test
fun `does not map unmapped http status code to SpanStatus`() {
val sut = fixture.getSut(httpStatusCode = 502)
sut.newCall(getRequest()).execute()
val httpClientSpan = fixture.sentryTracer.children.first()
assertEquals(502, httpClientSpan.data[SpanDataConvention.HTTP_STATUS_CODE_KEY])
assertNull(httpClientSpan.status)
}
@Test
fun `adds breadcrumb when http calls succeeds`() {
val sut = fixture.getSut(responseBody = "response body")
sut.newCall(postRequest()).execute()
verify(fixture.hub).addBreadcrumb(
check<Breadcrumb> {
assertEquals("http", it.type)
assertEquals(13L, it.data[SpanDataConvention.HTTP_RESPONSE_CONTENT_LENGTH_KEY])
assertEquals(12L, it.data["http.request_content_length"])
},
anyOrNull()
)
}
@SuppressWarnings("SwallowedException")
@Test
fun `adds breadcrumb when http calls results in exception`() {
// to setup mocks
fixture.getSut()
val interceptor = SentryOkHttpInterceptor(fixture.hub)
val chain = mock<Interceptor.Chain>()
whenever(chain.call()).thenReturn(mock())
whenever(chain.proceed(any())).thenThrow(IOException())
whenever(chain.request()).thenReturn(getRequest())
try {
interceptor.intercept(chain)
fail()
} catch (e: IOException) {
// ignore me
}
verify(fixture.hub).addBreadcrumb(
check<Breadcrumb> {
assertEquals("http", it.type)
},
anyOrNull()
)
}
@SuppressWarnings("SwallowedException")
@Test
fun `sets status and throwable when call results in IOException`() {
val sut = fixture.getSut(socketPolicy = SocketPolicy.DISCONNECT_AT_START)
try {
sut.newCall(getRequest()).execute()
fail()
} catch (e: IOException) {
// ignore
}
val httpClientSpan = fixture.sentryTracer.children.first()
assertNull(httpClientSpan.data[SpanDataConvention.HTTP_STATUS_CODE_KEY])
assertEquals(SpanStatus.INTERNAL_ERROR, httpClientSpan.status)
assertTrue(httpClientSpan.throwable is IOException)
}
@Test
fun `customizer modifies span`() {
val sut = fixture.getSut(
beforeSpan = { span, _, _ ->
span.description = "overwritten description"
span
}
)
val request = getRequest()
sut.newCall(request).execute()
assertEquals(1, fixture.sentryTracer.children.size)
val httpClientSpan = fixture.sentryTracer.children.first()
assertEquals("overwritten description", httpClientSpan.description)
assertTrue(httpClientSpan.isFinished)
}
@Test
fun `customizer receives request and response`() {
val sut = fixture.getSut(
beforeSpan = { span, request, response ->
assertEquals(request.url, request.url)
assertEquals(request.method, request.method)
assertNotNull(response) {
assertEquals(201, it.code)
}
span
}
)
val request = getRequest()
sut.newCall(request).execute()
}
@Test
fun `customizer can drop the span`() {
val sut = fixture.getSut(
beforeSpan = { _, _, _ -> null }
)
sut.newCall(getRequest()).execute()
val httpClientSpan = fixture.sentryTracer.children.first()
assertTrue(httpClientSpan.isFinished)
assertNotNull(httpClientSpan.spanContext.sampled) {
assertFalse(it)
}
}
@Test
fun `captures failed requests by default`() {
val sut = fixture.getSut(
httpStatusCode = 500,
captureFailedRequests = null
)
sut.newCall(getRequest()).execute()
verify(fixture.hub).captureEvent(any(), any<Hint>())
}
@Test
fun `captures an event if captureFailedRequests is enabled and within the range`() {
val sut = fixture.getSut(
captureFailedRequests = true,
httpStatusCode = 500
)
sut.newCall(getRequest()).execute()
verify(fixture.hub).captureEvent(any(), any<Hint>())
}
@Test
fun `does not capture an event if captureFailedRequests is disabled`() {
val sut = fixture.getSut(
httpStatusCode = 500
)
sut.newCall(getRequest()).execute()
verify(fixture.hub, never()).captureEvent(any(), any<Hint>())
}
@Test
fun `does not capture an event if captureFailedRequests is enabled and not within the range`() {
// default status code 201
val sut = fixture.getSut(
captureFailedRequests = true
)
sut.newCall(getRequest()).execute()
verify(fixture.hub, never()).captureEvent(any(), any<Hint>())
}
@Test
fun `does not capture an event if captureFailedRequests is enabled and not within the targets`() {
val sut = fixture.getSut(
captureFailedRequests = true,
httpStatusCode = 500,
failedRequestTargets = listOf("myapi.com")
)
sut.newCall(getRequest()).execute()
verify(fixture.hub, never()).captureEvent(any(), any<Hint>())
}
@Test
fun `captures an error event with hints`() {
val sut = fixture.getSut(
captureFailedRequests = true,
httpStatusCode = 500
)
sut.newCall(getRequest()).execute()
verify(fixture.hub).captureEvent(
any(),
check<Hint> {
assertNotNull(it.get(TypeCheckHint.OKHTTP_REQUEST))
assertNotNull(it.get(TypeCheckHint.OKHTTP_RESPONSE))
}
)
}
@Test
fun `captures an error event with request and response fields set`() {
val statusCode = 500
val sut = fixture.getSut(
captureFailedRequests = true,
httpStatusCode = statusCode,
responseBody = "fail",
sendDefaultPii = true
)
val request = getRequest(url = "/hello?myQuery=myValue#myFragment")
val response = sut.newCall(request).execute()
verify(fixture.hub).captureEvent(
check {
val sentryRequest = it.request!!
assertEquals("http://localhost:${fixture.server.port}/hello", sentryRequest.url)
assertEquals("myQuery=myValue", sentryRequest.queryString)
assertEquals("myFragment", sentryRequest.fragment)
assertEquals("GET", sentryRequest.method)
// because of isSendDefaultPii
assertNotNull(sentryRequest.headers)
assertNull(sentryRequest.cookies)
val sentryResponse = it.contexts.response!!
assertEquals(statusCode, sentryResponse.statusCode)
assertEquals(response.body!!.contentLength(), sentryResponse.bodySize)
// because of isSendDefaultPii
assertNotNull(sentryResponse.headers)
assertNull(sentryResponse.cookies)
assertTrue(it.throwable is SentryHttpClientException)
},
any<Hint>()
)
}
@Test
fun `captures an error event with request body size`() {
val sut = fixture.getSut(
captureFailedRequests = true,
httpStatusCode = 500
)
val body = "fail"
.toRequestBody(
"text/plain"
.toMediaType()
)
sut.newCall(postRequest(body = body)).execute()
verify(fixture.hub).captureEvent(
check {
val sentryRequest = it.request!!
assertEquals(body.contentLength(), sentryRequest.bodySize)
},
any<Hint>()
)
}
@Test
fun `captures an error event with headers`() {
val sut = fixture.getSut(
captureFailedRequests = true,
httpStatusCode = 500,
sendDefaultPii = true
)
sut.newCall(getRequest()).execute()
verify(fixture.hub).captureEvent(
check {
val sentryRequest = it.request!!
assertEquals("myValue", sentryRequest.headers!!["myHeader"])
val sentryResponse = it.contexts.response!!
assertEquals("myValue", sentryResponse.headers!!["myResponseHeader"])
},
any<Hint>()
)
}
@SuppressWarnings("SwallowedException")
@Test
fun `does not capture an error even if it throws`() {
// to setup mocks
fixture.getSut()
val interceptor = SentryOkHttpInterceptor(
fixture.hub,
captureFailedRequests = true
)
val chain = mock<Interceptor.Chain>()
whenever(chain.call()).thenReturn(mock())
whenever(chain.proceed(any())).thenThrow(IOException())
whenever(chain.request()).thenReturn(getRequest())
try {
interceptor.intercept(chain)
fail()
} catch (e: IOException) {
// ignore me
}
verify(fixture.hub, never()).captureEvent(any(), any<Hint>())
}
@Test
fun `when a call is captured by SentryOkHttpEventListener no span nor breadcrumb is created`() {
val sut = fixture.getSut(responseBody = "response body")
val call = sut.newCall(postRequest())
SentryOkHttpEventListener.eventMap[call] = mock()
call.execute()
val httpClientSpan = fixture.sentryTracer.children.firstOrNull()
assertNull(httpClientSpan)
verify(fixture.hub, never()).addBreadcrumb(any<Breadcrumb>(), anyOrNull())
}
@Test
fun `when a call is not captured by SentryOkHttpEventListener, client error is reported`() {
val sut = fixture.getSut(captureFailedRequests = true, httpStatusCode = 500)
val call = sut.newCall(getRequest())
call.execute()
verify(fixture.hub).captureEvent(any(), any<Hint>())
}
@Test
fun `when a call is captured by SentryOkHttpEventListener no client error is reported`() {
val sut = fixture.getSut(captureFailedRequests = true, httpStatusCode = 500)
val call = sut.newCall(getRequest())
SentryOkHttpEventListener.eventMap[call] = mock()
call.execute()
verify(fixture.hub, never()).captureEvent(any(), any<Hint>())
}
}