-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make other dependencies into submodules (#156) #414
Conversation
Thanks for the contribution. There is still no clear answer whether we want to go this route or not, as we'd have to update our release process for this SDK. It may take some time until we make a decision, so please be patient, thanks. Original ref: #156 (There is apparently one redundant line in |
go1.17- also can works keep the original dependency version
deleted |
Hello @kamilogorek , do you have any updates about this? I got several CVE notifications just because this sdk has kataras/iris as a direct dependency, a submodule structure would so much cleaner. |
@marco-bianchi-bee what version of Go are you using? Since Once Reference for self:
|
@kamilogorek thank you for your answer I am using |
@marco-bianchi-bee snyk is using |
@kamilogorek hello any progress on this? I had to remove sentry as a dependency because the security issues keep piling up. |
@marco-bianchi-bee security issues should be resolved in |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
go1.17- also can works
keep the original dependency version