You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment sentry-go has (test) dependency on: github.com/pkg/errors, github.com/go-errors/errors and github.com/pingcap/errors.
Those are not strictly necessary, because all we care about is replicating the particular behavior of those libraries (extended interfaces on their specific error types).
Seldom, but surely, our CI fails unnecessarily because of changes in those dependencies, see #235 (comment).
In raven-go, this very same removal (for pkg/errors) has been done in getsentry/raven-go#228.
Steps To Reproduce
This is an example of CI failure because of the dependency, but unrelated to the functionality we care about:
Summary
At the moment
sentry-go
has (test) dependency on:github.com/pkg/errors
,github.com/go-errors/errors
andgithub.aaakk.us.kg/pingcap/errors
.Those are not strictly necessary, because all we care about is replicating the particular behavior of those libraries (extended interfaces on their specific error types).
Seldom, but surely, our CI fails unnecessarily because of changes in those dependencies, see
#235 (comment).
In
raven-go
, this very same removal (forpkg/errors
) has been done in getsentry/raven-go#228.Steps To Reproduce
This is an example of CI failure because of the dependency, but unrelated to the functionality we care about:
Expected Behavior
sentry-go
should not depend on the packages listed above. CI should not fail if any of those packages are broken.Screenshots
SDK
sentry-go
version: masterAdditional context
This is also related to #156, as it would reduce the number of entries in
go.mod
.The text was updated successfully, but these errors were encountered: