Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span op and span name should be split #61

Open
BYK opened this issue Aug 30, 2022 · 3 comments
Open

Span op and span name should be split #61

BYK opened this issue Aug 30, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@BYK
Copy link
Member

BYK commented Aug 30, 2022

Right now the spans take the name of the steps as their "operation" and their names are empty. I'd argue that names should be mapped to names and operation should be something like uses: actions/checkout@v3 etc.

@armenzg
Copy link
Member

armenzg commented Aug 30, 2022

Yes, definitely. This is something I did not understand well.

@AbhiPrasad
Copy link
Member

We did try to develop a standard list of span operations - perhaps we can pull from there, or add to that list: https://develop.sentry.dev/sdk/performance/span-operations/

@BYK
Copy link
Member Author

BYK commented Sep 2, 2022

We should probably add. The closest I find is https://develop.sentry.dev/sdk/performance/span-operations/#messagesqueues but only job.exec applies there to an extent.

@armenzg armenzg added this to the Hack Week 2023 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants