New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using workflow runs for the webhooks #30

Open

armenzg opened this issue May 24, 2022 · 1 comment

Milestone

Github App to sup...

Member

armenzg commented May 24, 2022

We're currently using workflow jobs:

@asottile-sentry mentions that it is possible to use workflow runs for this app. This was not originally available when the prototype was written.

This could potentially save these extra two calls:
https://github.com/getsentry/github-actions-app/blob/09c1a16e717ad750dc3b249ebb214356492c949b/src/github_sdk.py#L43-L44

That could potentially save more than 70% of the execution time:

armenzg added this to the Github App to support external orgs milestone

Member Author

armenzg commented Jun 2, 2022

This may be necessary to avoid having to change permissions for external orgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment