-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAUI - IOS - Apple Store - Build rejected - Sentry contains bitcode #2022
Comments
Hi! Thanks for reporting this. I'll investigate asap. |
@legrignotin - Could I ask you please to try again with the latest 3.23.0-preview.3 just published? (It has Sentry.Cocoa 7.28.0). I think you will get the same thing, but I'm not certain. Thanks. |
@philipphofmann @brustolin - I think this is related to getsentry/sentry-cocoa#2304, getsentry/sentry-cocoa#2307, and getsentry/sentry-cocoa#2332 The build of Sentry.Maui reported was using Sentry.Cocoa 7.24.1 - but it's a custom build due to the Catalyst issue The error appears to be saying that bitcode isn't allowed at all now, so I'm confused by 7.29.0 enabling it. Am I missing something? I also want to see what happens with the newer version. I updated to 7.28.0, and I'm pretty sure I had XCode 14 for that one. |
@mattjohnsonpint |
Thanks for letting us know. I'm glad it's working now! @philipphofmann - I'm still concerned that the next version might break it again, given bitcode was just turned on in 7.29.0. Thoughts? |
Keeping this open for now, due to another report of this |
Yea I'm having the same issue with 3.23 preview-3 |
@legrignotin @GolfJimB - Can you please each tell me which version of XCode you are using on the mac you are building and submitting to the App Store with? The situation appears that XCode 13 and prior required bitcode enabled for libraries and frameworks, when the application itself had bitcode enabled. (per getsentry/sentry-cocoa#2304) But with XCode 14, bitcode is deprecated and is required to be disabled, and is by default. At least, that's my interpretation of the following in the XCode 14 release notes:
I'm still not sure why using |
Xcode 14.0.1 (21336) with iOS16 targeted and .net 7.0. FYI my web app that uses Sentry.AspNetCore is in the same solution and I had to remove that too for apple to accept my latest build. (That was also version 3.23.0) |
Thanks for the details. We'll keep investigating. Yes, that second part would makes sense, assuming you have a common library that you are using both in your main app and your web app and Sentry is used in that library. The full dependency tree (for iOS) is:
The issue in question is in the Sentry Cocoa SDK. |
Crisis averted, I had an old version of Sentry referenced in another library. I updated that and now it works. Thanks guys, love the product! |
@GolfJimB - Just to confirm, 3.23.0 did indeed work all the way through publishing to the app store? |
Yep, all good |
Hey @mattjohnsonpint we were receiving complains about our Carthage project not having bitcode enabled. Until Xcode 13, bitcode was enabled by default and all SDK versions had it enabled. Xcode 14 disabled it, we had to manually turn it on to not introduce a breaking change. Unity project did not compile with Bitcode disabled, and old projects started to showing an annoying warning. I didn't know Apple was rejecting new projects with Bitcode enabled. So it looks like to solution is to disabled it and tell users to also disabled it. |
cc @bitsandfoxes |
@brustolin - Thanks. That aligns with what I was seeing as well. Since our 3.23.0 includes a version with bitcode disabled, and @legrignotin and @GolfJimB has confirmed that is working, then I'll close this issue. We'll be sure to wait to update the Cocoa SDK again until bitcode is re-disabled there. Thanks everyone! |
Package
Sentry.Maui
.NET Version
6.0.402
SDK Version
3.22.0-preview.3
Steps to Reproduce
- task: DotNetCoreCLI@2 displayName: 'Build and Sign IOS App' inputs: command: 'publish' publishWebProjects: false projects: '**/Mobile.csproj' arguments: '-f net6.0-ios -c $(BuildConfiguration) /p:ArchiveOnBuild=true /p:CodesignKey="$(AppleCodesignKey)" /p:CodesignProvision="$(AppleCodesignProvision)" -o $(build.artifactstagingdirectory)/ios/' zipAfterPublish: false modifyOutputPath: false
Microsoft Job used
Expected Result
The build appears in test flight without any error.
Actual Result
The pipeline show the following warning:
Waiting for the build to show up in the build list - this may take a few minutes (check your email for processing issues if this continues)
I got an e-mail with the following error:
ITMS-90482: Invalid Executable - The executable 'Mobile.app/Frameworks/Sentry.framework/Sentry' contains bitcode.
The text was updated successfully, but these errors were encountered: