From 140fac1e7b0a52ca27fbb999aaee39212a455f65 Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Tue, 23 Jan 2024 10:00:07 -0500 Subject: [PATCH 1/4] enable windows again --- .github/workflows/dart.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 2eedf96de9..779cf5ea90 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -31,8 +31,7 @@ jobs: strategy: fail-fast: false matrix: - # TODO: exclude windows for now, because of failing tests in the new image runner - os: [ubuntu-latest, macos-latest] + os: [ubuntu-latest, windows-latest, macos-latest] sdk: [stable, beta] exclude: - os: windows-latest From 269c32a3f0ed5996d3eb1fa1e50b9834ecce15b8 Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Tue, 23 Jan 2024 10:34:26 -0500 Subject: [PATCH 2/4] test with chrome --- .github/workflows/dart.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 779cf5ea90..0b75625f8b 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -48,8 +48,8 @@ jobs: run: | dart pub get dart test -p chrome --test-randomize-ordering-seed=random --chain-stack-traces - dart test -p vm --coverage=coverage --test-randomize-ordering-seed=random --chain-stack-traces - dart pub run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib +# dart test -p vm --coverage=coverage --test-randomize-ordering-seed=random --chain-stack-traces +# dart pub run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib - name: Install webdev if: runner.os != 'Windows' From 4c8f290b68efecb406d40bb0d6bee102658afb6d Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Tue, 23 Jan 2024 10:41:23 -0500 Subject: [PATCH 3/4] test with chrome --- .github/workflows/dart.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 0b75625f8b..9991c390c3 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -47,8 +47,8 @@ jobs: - name: Test (VM and browser) run: | dart pub get - dart test -p chrome --test-randomize-ordering-seed=random --chain-stack-traces -# dart test -p vm --coverage=coverage --test-randomize-ordering-seed=random --chain-stack-traces +# dart test -p chrome --test-randomize-ordering-seed=random --chain-stack-traces + dart test -p vm --coverage=coverage --test-randomize-ordering-seed=random --chain-stack-traces # dart pub run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib - name: Install webdev From 6d3a5561fc42813dda8326d61520c85d1474ad69 Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Wed, 24 Jan 2024 12:17:23 -0500 Subject: [PATCH 4/4] reenable windows test --- .github/workflows/dart.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 9991c390c3..779cf5ea90 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -47,9 +47,9 @@ jobs: - name: Test (VM and browser) run: | dart pub get -# dart test -p chrome --test-randomize-ordering-seed=random --chain-stack-traces + dart test -p chrome --test-randomize-ordering-seed=random --chain-stack-traces dart test -p vm --coverage=coverage --test-randomize-ordering-seed=random --chain-stack-traces -# dart pub run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib + dart pub run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib - name: Install webdev if: runner.os != 'Windows'