Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database instrumentation for Isar #1501

Closed
silverhairs opened this issue Jun 2, 2023 · 4 comments · Fixed by #1726 or #1800
Closed

Database instrumentation for Isar #1501

silverhairs opened this issue Jun 2, 2023 · 4 comments · Fixed by #1726 or #1800

Comments

@silverhairs
Copy link

silverhairs commented Jun 2, 2023

Problem Statement

Isar is getting more and more adoption in the space; maybe not as popular as sqflite yet but it still is one of the highest rated packages on pub.dev. I think it's worth having a package that provides instrumentation for this, like sentry_sqflite.

Solution Brainstorm

Isar has a companion app called Isar Inspector that acts as a database client and gives a visual representation of transactions being performed, I think it's worth looking at that side.

Are you willing to submit a PR?

None

@marandaneto
Copy link
Contributor

@silverhairs makes sense, I tried to investigate it here #1204 but that solution didn't work out (based on File support).
We'd need to do a wrapper on top of the Isar classes since they don't have the concept of interceptors or something like that, at least I've not found it last time I checked it.

@silverhairs
Copy link
Author

@silverhairs makes sense, I tried to investigate it here #1204 but that solution didn't work out (based on File support). We'd need to do a wrapper on top of the Isar classes since they don't have the concept of interceptors or something like that, at least I've not found it last time I checked it.

@marandaneto Thanks for trying 🙏 I don't exactly have time at the moment but when I get some time and this issue is still open I would like to take a look at this and I believe your experiment will be very valuable.

@marandaneto marandaneto moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jun 22, 2023
@denrase denrase moved this from Backlog to In Progress in Mobile & Cross Platform SDK Nov 7, 2023
@denrase denrase mentioned this issue Nov 14, 2023
6 tasks
@buenaflor buenaflor moved this from In Progress to Needs Review in Mobile & Cross Platform SDK Nov 28, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Mobile & Cross Platform SDK Dec 19, 2023
@denrase denrase reopened this Dec 27, 2023
@denrase
Copy link
Collaborator

denrase commented Dec 27, 2023

Reopened because we still need to implement breadcrumbs.

@denrase denrase mentioned this issue Jan 2, 2024
6 tasks
@buenaflor
Copy link
Contributor

@denrase

  • update sentry-docs with Isar instrumentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants