Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SentryEnvelopeHeader#sent_at #1337

Closed
Tracked by #32
marandaneto opened this issue Mar 16, 2023 · 1 comment · Fixed by #1428
Closed
Tracked by #32

Support SentryEnvelopeHeader#sent_at #1337

marandaneto opened this issue Mar 16, 2023 · 1 comment · Fixed by #1428
Assignees
@denrase
Labels
Platform: Dart repository maintenance
Milestone
7.x

Comments

@marandaneto
Copy link
Contributor

Description

Context getsentry/team-mobile#32
We have to check if this field has to be generated during the event creation or sending (thru Native SDKs).
Maybe requires adding this field to Native SDKs as well.
@marandaneto marandaneto added this to the 8.1.0 milestone Mar 16, 2023
@marandaneto marandaneto mentioned this issue Mar 16, 2023
Closed
@marandaneto marandaneto modified the milestones: 8.1.0, 7.x Mar 21, 2023
@marandaneto marandaneto moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 30, 2023
@denrase denrase moved this from Backlog to In Progress in Mobile & Cross Platform SDK Apr 4, 2023
This was referenced Apr 4, 2023
Merged
Merged
@marandaneto
Copy link
Contributor Author

There's one thing missing yet, if not using the native integrations, setting the sent_at should be done on the Dart side as well, closer to the transport layer, similar to Android and iOS.

@denrase denrase mentioned this issue May 9, 2023
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denrase denrase

Labels
Platform: Dart repository maintenance
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
7.x
Development

Successfully merging a pull request may close this issue.

Add sent_at to envelope header getsentry/sentry-dart
2 participants
@denrase @marandaneto