Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App, Culture Context for Crashes #2524

Closed
philipphofmann opened this issue Dec 13, 2022 · 2 comments
Closed

App, Culture Context for Crashes #2524

philipphofmann opened this issue Dec 13, 2022 · 2 comments

Comments

@philipphofmann
Copy link
Member

Description

Before #2523, the SentryClient attached out-of-date context data to crashes. Instead of attaching the data in the SentryClient, we should put that data in the scope of the global hub, which automatically syncs the data to the scope of SentryCrash by using SentrySDK.currentHub configureScope.

The SDK already adds similar data to the scope in the SentryCrashIntegration, but this has the downside of having less context when disabling the SentryCrashIntegration. We could create an extra integration called SentryEventContextEnricher or something like that, and move the code form the SentryClient to this integration.

@armcknight
Copy link
Member

Here’s the original pr that attached the context: #2036

@brustolin brustolin moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Dec 14, 2022
@brustolin brustolin changed the title App, Permission and Culture Context for Crashes App, Culture Context for Crashes Dec 14, 2022
@brustolin brustolin added this to the 8.0.0 milestone Dec 14, 2022
@philipphofmann philipphofmann removed this from the 8.0.0 milestone Jan 4, 2023
@philipphofmann philipphofmann self-assigned this Jan 12, 2023
@philipphofmann philipphofmann removed their assignment Mar 29, 2023
@philipphofmann
Copy link
Member Author

This was fixed with #3699.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants